From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1520FC432BE for ; Sun, 8 Aug 2021 15:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6DD760F4B for ; Sun, 8 Aug 2021 15:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231983AbhHHPSh (ORCPT ); Sun, 8 Aug 2021 11:18:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38792 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbhHHPSh (ORCPT ); Sun, 8 Aug 2021 11:18:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IX6iXJR0gdOvuN0kjkDx8GxE+mezPMmx72SsWSZD468=; b=Xz7KwTC+TkeF0IbjWDSRYb02dp AzBo0pJjr+W43TgQ2ELghz2eGhoPWcZPiOKEmJmRjyGw+d8DXzAx2nGxOoghaS+iOns1R4FJZXsBM 5XcRdOGOuPEuX4A2hZhdzPVDyF5KfWo5ccORIMjZ/lbGcxfvxOlG56+tI5HyiNXIEzHA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mCkYq-00Gaij-Qa; Sun, 08 Aug 2021 17:18:00 +0200 Date: Sun, 8 Aug 2021 17:18:00 +0200 From: Andrew Lunn To: Daniel Golle Cc: Michael Walle , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] ARM: kirkwood: add missing for ETH_ALEN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > When building OpenWrt kernel which includes a backport of > "of: net: pass the dst buffer to of_get_mac_address()", this is not the > same as doesn't include yet. This is > because we miss commit 0c65b2b90d13c1 ("net: of_get_phy_mode: Change > API to solve int/unit warnings") which has been in mainline for a long > time. That is quiet a big invasive patch, so i can understand it not being backported. But on the flip side, it will make it harder getting drivers upstream to mainline. And there are is one other big change, how the MAC address is fetches from EEPROM, DT, etc. > Sorry for the noise caused, I'm not sure what the policy is in this > case There is nothing in the coding style that all headers must be directly included in the .c file. And it slows down the compiler having to pull in a header file multiple times. You do see patches removing unused includes. So i think OpenWRT should add yet another patch do deal with its own breakage. If you have more kirkwood, or Marvell boards in general in OpenWRT which you want merged to mainline, i'm happy to review them. Andrew