mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Beguin <lvb@xiphos.com>
To: Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	kernel test robot <lkp@intel.com>,
	"liambeguin@gmail.com" <liambeguin@gmail.com>
Subject: RE: [PATCH 2/2] clk: lmk04832: Use of match table
Date: Tue, 29 Jun 2021 15:03:49 +0000	[thread overview]
Message-ID: <YQBPR0101MB1811DDE8C4D8802A082E77DFD8029@YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210629060751.3119453-2-sboyd@kernel.org>



> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>
> Cc: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; kernel test
> robot <lkp@intel.com>; Liam Beguin <lvb@xiphos.com>
> Subject: [PATCH 2/2] clk: lmk04832: Use of match table
> 
> Presumably we want to use this match table so add a module device table
> and set the driver match pointer appropriately.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Liam Beguin <lvb@xiphos.com>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>

Reviewed-by: Liam Beguin <lvb@xiphos.com>

> ---
>  drivers/clk/clk-lmk04832.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index 0cd76e626c3d..c1095e733220 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device
> *spi)
>  }
>  static const struct spi_device_id lmk04832_id[] = {
>  	{ "lmk04832", LMK04832 },
> -	{},
> +	{}
>  };
>  MODULE_DEVICE_TABLE(spi, lmk04832_id);
> 
>  static const struct of_device_id lmk04832_of_id[] = {
>  	{ .compatible = "ti,lmk04832" },
> -	{},
> +	{}
>  };
> +MODULE_DEVICE_TABLE(of, lmk04832_of_id);
> 
>  static struct spi_driver lmk04832_driver = {
>  	.driver = {
>  		.name	= "lmk04832",
> +		.of_match_table = lmk04832_of_id,
>  	},
>  	.probe		= lmk04832_probe,
>  	.remove		= lmk04832_remove,
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git


  reply	other threads:[~2021-06-29 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  6:07 [PATCH 1/2] clk: lmk04832: Depend on SPI Stephen Boyd
2021-06-29  6:07 ` [PATCH 2/2] clk: lmk04832: Use of match table Stephen Boyd
2021-06-29 15:03   ` Liam Beguin [this message]
2021-06-29 15:01 ` [PATCH 1/2] clk: lmk04832: Depend on SPI Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQBPR0101MB1811DDE8C4D8802A082E77DFD8029@YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM \
    --to=lvb@xiphos.com \
    --cc=liambeguin@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®