From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 211D3C4338F for ; Fri, 30 Jul 2021 08:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1DAD60EB2 for ; Fri, 30 Jul 2021 08:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238080AbhG3IXU (ORCPT ); Fri, 30 Jul 2021 04:23:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231939AbhG3IXT (ORCPT ); Fri, 30 Jul 2021 04:23:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B344860EB2; Fri, 30 Jul 2021 08:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627633395; bh=XienLPypcT4jafbAb8E33tAQFMRDgUBzkXinX5F9wpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yx/G7xZb46VOfBacHThzsYc15i4H4qGxulqdiRlyro/2sqPqd9Km7UjwqKGI08LUD Wf/d5rcKTOvP4VRDexS7iayUAJSlQ7Au4FH1ZGEDyXRgPn0xNDj2JgRxl/6BB5ChGW Bhh66FCQ3Q3g+Ms5N+IxS5bNdfgQ7d6eQEZq/SwA= Date: Fri, 30 Jul 2021 10:23:12 +0200 From: Greg KH To: Larry Finger Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] staging: r8188eu: Remove header file include/rtw_version.h Message-ID: References: <20210729170930.23171-1-Larry.Finger@lwfinger.net> <20210729170930.23171-6-Larry.Finger@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729170930.23171-6-Larry.Finger@lwfinger.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 12:09:29PM -0500, Larry Finger wrote: > This file contains only the definition of the driver version. This statement > is moved into a header called by all the affected source files, and the now > empty header is deleted. And now that the driver is in the tree, the "version" can be removed entirely. But that's for a later patch :) Thanks for all of these cleanups, now applied. greg k-h