From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46185C4338F for ; Thu, 5 Aug 2021 11:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D6E961102 for ; Thu, 5 Aug 2021 11:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240629AbhHELCb (ORCPT ); Thu, 5 Aug 2021 07:02:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240551AbhHELC0 (ORCPT ); Thu, 5 Aug 2021 07:02:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 44A64610CC; Thu, 5 Aug 2021 11:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628161331; bh=ZTRYMBgLQMHnfEDLljdtt2hgoITgQbD7wf+/G6oaRGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IOwkk/VkD9lBsvOk4zMCY/YQxekSrFQlri6wLVo1cLZeF0Uk7VetEt69ZFOVQ0y1A QgzrbDOGXv0P6F+FC/MX3FQaLJKu8y7kZwBsQm5cB11Wa15d3nMUBxSfe096QxLtpo DpPu/bURVutRomG6lz68bvHpJD7kocw3cO54s4/0= Date: Thu, 5 Aug 2021 13:02:09 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] staging: r8188eu: remove RT_TRACE and DBG_88E prints from xmit_linux.c Message-ID: References: <20210803201511.29000-1-martin@kaiser.cx> <20210803201511.29000-6-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210803201511.29000-6-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 03, 2021 at 10:15:11PM +0200, Martin Kaiser wrote: > We should use the standard mechanism for debug prints. Remove the prints > that use driver-specific macros. It is ok to remove the RT_TRACE macros, but you are removing the other debugging calls and are not replacing them with anything. Are you sure that is ok? Why not use the proper debugging calls instead of just deleting them? thanks, greg k-h