From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED57C432BE for ; Thu, 5 Aug 2021 11:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AA9561102 for ; Thu, 5 Aug 2021 11:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232907AbhHELi2 (ORCPT ); Thu, 5 Aug 2021 07:38:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:40528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241080AbhHELiX (ORCPT ); Thu, 5 Aug 2021 07:38:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BBDD960C51; Thu, 5 Aug 2021 11:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628163488; bh=ugZWR/yfSjuppoNeY9Xc2waupdhAYEJVcwZWQy5UVz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jSxJyvEDQq7T5RXxWwCfec8wKcUrnEsXVl0F8bbzoQOPMTzfxNygKG6Z2GxA1ZtOi I0R1FQDy8bchr8WX0iVDP/0ZUOfavf/29fRyRCn8K7r5Vsy5oKA2wl5ayitsYgk8VW YZSKECv4rjzH4gnbyJ8lUYB7jlyFwyFTOCqOfctk= Date: Thu, 5 Aug 2021 13:38:05 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Len Baker , Andy Shevchenko , Phil Reid , Geert Uytterhoeven , dri-devel , "open list:FRAMEBUFFER LAYER" , linux-staging@lists.linux.dev, Linux Kernel Mailing List Subject: Re: [PATCH v3 0/3] Remove all strcpy() uses Message-ID: References: <20210801085155.3170-1-len.baker@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 05, 2021 at 02:30:35PM +0300, Andy Shevchenko wrote: > On Thu, Aug 5, 2021 at 2:18 PM Greg Kroah-Hartman > wrote: > > On Sun, Aug 01, 2021 at 02:40:40PM +0300, Andy Shevchenko wrote: > > > On Sun, Aug 1, 2021 at 11:53 AM Len Baker wrote: > > > > > > > > strcpy() performs no bounds checking on the destination buffer. This > > > > could result in linear overflows beyond the end of the buffer, leading > > > > to all kinds of misbehaviors. So, this serie removes all strcpy uses > > > > from the "staging/fbtft" subsystem. > > > > > > > > Also, refactor the code a bit to follow the kernel coding-style and > > > > avoid unnecessary variable initialization. > > > > > > I don't see patch 3 (even on lore.kernel.org). > > > > > > Greg, Geert, does it make sense to move this driver outside of staging? > > > > If you clean up everything that needs to be done, yes, please do. > > Do we have a clear TODO for that? > > The current one has the item which is not feasible to achieve in > reasonable time. Some of those drivers won't be converted to tiny DRM. > So the idea is to keep this out of staging in the maintenance phase > (as it currently states, i.e. no new drivers accepted). For the rest > I'm not sure what else can be done (checkpatch? coccinelle?). > Actually the first sentence in this paragraph is a motivation for > moving out of staging. Take it up with the DRM developers/maintainers. If they approve for this to move out of staging without being converted over to use tiny DRM, then I am fine to move it out. thnks, greg k-h