From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18609C4320E for ; Tue, 10 Aug 2021 08:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFB0760234 for ; Tue, 10 Aug 2021 08:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237004AbhHJIrH (ORCPT ); Tue, 10 Aug 2021 04:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233034AbhHJIrA (ORCPT ); Tue, 10 Aug 2021 04:47:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E263C0613D3; Tue, 10 Aug 2021 01:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rb4AJ3RpTEpnwHFGufrRXvpNIl3SykHPZcUGM6sSAhU=; b=sefWE1vye7O2LBnpxizIRl1uJk FJ1kmk0NBO8bSAgycCHQwqzgbZ5DNQ9oEzSNvTr0Ca0HEc2HfXPrew4rcHyEILGQcQSzTrsy7mutg cdTdehwzAoxcLkWSKHtMy+UVYwHQG4FvVfxvbx08Y2FQT+woIP6YIJZfQwxatshtkWp5CMbCJUEja T2z88qNgdcTkxzFvr8vOtCREbvU3dms9BKkVxhNF+lugwbwQnnMMYZ0TfpQwrWMuGahS6d+c+Ii3j BiBuFdvCEQEKXWCUTAqNRKwaHyCs55DPKhZuSI95TjbDkY2H5xTip8N8RXHVt1L1b23lDphGrCPiB 5OvmhrIA==; Received: from [2001:4bb8:184:6215:a004:cea2:5ea9:6eca] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDNNx-00BuPt-7E; Tue, 10 Aug 2021 08:45:33 +0000 Date: Tue, 10 Aug 2021 10:45:20 +0200 From: Christoph Hellwig To: Alex Williamson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jgg@nvidia.com, peterx@redhat.com Subject: Re: [PATCH 2/7] vfio: Export unmap_mapping_range() wrapper Message-ID: References: <162818167535.1511194.6614962507750594786.stgit@omen> <162818324222.1511194.15934590640437021149.stgit@omen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162818324222.1511194.15934590640437021149.stgit@omen> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +void vfio_device_unmap_mapping_range(struct vfio_device *device, > + loff_t start, loff_t len) > +{ > + unmap_mapping_range(device->inode->i_mapping, start, len, true); > +} > +EXPORT_SYMBOL_GPL(vfio_device_unmap_mapping_range); Instead of mirroring the name of unmap_mapping_range maybe give this a name to document the use case? > +extern void vfio_device_unmap_mapping_range(struct vfio_device *device, > + loff_t start, loff_t len); No need for the extern.