From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C4EC432BE for ; Tue, 31 Aug 2021 20:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA48360ED4 for ; Tue, 31 Aug 2021 20:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241302AbhHaUy6 (ORCPT ); Tue, 31 Aug 2021 16:54:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50718 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234503AbhHaUyy (ORCPT ); Tue, 31 Aug 2021 16:54:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lfAFcCGlGT+Q4w/q2JAsedWr3zWRkAZESjJDBTuaMdo=; b=Us9V68I49hWALcyGFeZoj9Jl9f swTJDnwVPfBLdKaAwkI0h5biF9FMvllHT0WagBhXXLpnfBukjedib6racgmhY/F4+sITOPliO1nS1 pos4rTWZmShEjE47gPqfYDGeSyNM6EPaxNgjHuB53Nm0ioHjV63D6FR1Q2UsMXDjttT8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mLAl2-004kzH-JI; Tue, 31 Aug 2021 22:53:24 +0200 Date: Tue, 31 Aug 2021 22:53:24 +0200 From: Andrew Lunn To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Maxime Ripard , Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= , Willy Liu , Rob Herring , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Message-ID: References: <20210830151645.18018-1-u@pkh.me> <116454729.UZi3dMzWh7@jernej-laptop> <1746741.3t3T1tWQfl@kista> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1746741.3t3T1tWQfl@kista> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > True, but then again, DT is a bit special, since it's not used only by Linux. > It's shared at least with BSDs and U-Boot, which most likely have independent > driver implementation. That's why it's good to have DT fixes referencing DT > related commits. As you said, DT described HW wrong. > > Looking at past Allwinner related DT commits regarding this issue, we were not > totally consistent. Most of them reference commit where emac node was > introduced in DT. But I also found a couple of commits which indeed have fixes > tag for bbc4d71d6354. All true, and it is not a big deal if it does go back further. I don't care, we can let the Allwinner Maintainer decide. Ah, that is you :-) I just want to try to keep it simple for somebody who is contributing their first Linux kernel patch. If it is good enough, i say accept it, and we can do a bit more education on the second contribution. Andre