From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F11C4320E for ; Wed, 1 Sep 2021 11:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2E0160F6C for ; Wed, 1 Sep 2021 11:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243700AbhIALhl (ORCPT ); Wed, 1 Sep 2021 07:37:41 -0400 Received: from mga06.intel.com ([134.134.136.31]:55785 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241703AbhIALhk (ORCPT ); Wed, 1 Sep 2021 07:37:40 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="279729838" X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="279729838" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2021 04:36:43 -0700 X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="466840713" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314) ([10.237.222.51]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2021 04:36:41 -0700 Date: Wed, 1 Sep 2021 12:36:33 +0100 From: Giovanni Cabiddu To: Andy Shevchenko Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Herbert Xu , Fiona Trahe , Wojciech Ziemba Subject: Re: drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28: warning: taking address of packed member 'csr_ops' of class or structure 'adf_hw_device_data' may result in an unaligned pointer value Message-ID: References: <202109010001.5r11IRSX-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2021 at 02:18:17PM +0300, Andy Shevchenko wrote: > On Wed, Sep 01, 2021 at 12:19:08AM +0800, kernel test robot wrote: > > >> drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28: warning: taking address of packed member 'csr_ops' of class or structure 'adf_hw_device_data' may result in an unaligned pointer value [-Waddress-of-packed-member] > > adf_gen2_init_hw_csr_ops(&hw_data->csr_ops); > > ^~~~~~~~~~~~~~~~ > > 3 warnings generated. > > > Why on Earth the struct adf_hw_device_data, that contains a lot of pointers, > marked as __packed?! That __packed has to be dropped. That struct doesn't need to be marked as __packed. I'm going to send a patch that drops that attribute for all the structures that do not need to be packed in the QAT driver. -- Giovanni