From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A70C432BE for ; Mon, 23 Aug 2021 01:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8039611CB for ; Mon, 23 Aug 2021 01:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234660AbhHWBps (ORCPT ); Sun, 22 Aug 2021 21:45:48 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33168 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234566AbhHWBpq (ORCPT ); Sun, 22 Aug 2021 21:45:46 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C2F112A5; Mon, 23 Aug 2021 03:45:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1629683104; bh=euWmE3CtpsP81m3SgrIa5KuUsrQe/fdxnN1qsqZYT/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X3Xu+rRxHf0qqAY3Q+DKrcVIJ3GqYcvHs+iShYDLqmk9K1FxLOYvl5Xj7Bg6pNM3m eO7LDOZAQRqJ9qLmMxOwihC7hYklGcIjrt9lEj0dx9N3xBjnwSchu8ET4sgPUd9CA8 isMjLz08Pn8LIDHfI6JmNC/24RwYk0OUTW2nZJoE= Date: Mon, 23 Aug 2021 04:44:54 +0300 From: Laurent Pinchart To: Pratyush Yadav Cc: Vinod Koul , Paul Kocialkowski , Tomi Valkeinen , Vignesh Raghavendra , Nikhil Devshatwar , Kishon Vijay Abraham I , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v4 6/6] phy: dt-bindings: cdns,dphy: add Rx DPHY compatible Message-ID: References: <20210820190346.18550-1-p.yadav@ti.com> <20210820190346.18550-7-p.yadav@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210820190346.18550-7-p.yadav@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pratyush, Thank you for the patch. On Sat, Aug 21, 2021 at 12:33:46AM +0530, Pratyush Yadav wrote: > The DPHY is treated to be in Tx mode by default. Add a new compatible > for Rx mode DPHYs. > > Signed-off-by: Pratyush Yadav > > --- > > Changes in v4: > - New in v4. > > Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > index d5a5e1f0b671..48b6a841152e 100644 > --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > @@ -11,8 +11,9 @@ maintainers: > > properties: > compatible: > - items: > + oneOf: > - const: cdns,dphy > + - const: cdns,dphy-rx It's customary to use an enum instead: compatibles: enum: - cdns,dphy - cdns,dphy-tx I don't know if Rob has a preference for consistency (or for any other reason). In either case, Reviewed-by: Laurent Pinchart > > reg: > maxItems: 1 -- Regards, Laurent Pinchart