From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF839C432BE for ; Thu, 26 Aug 2021 10:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D036610E9 for ; Thu, 26 Aug 2021 10:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241262AbhHZKIg (ORCPT ); Thu, 26 Aug 2021 06:08:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:44364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233880AbhHZKIf (ORCPT ); Thu, 26 Aug 2021 06:08:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C3FE610D1; Thu, 26 Aug 2021 10:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629972468; bh=x8NVmE1BdD+ZN1w2mIzfik5Ryle5HXnB166iXxfhU5Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SRDq68V/Z1MGrS0XStZqwlyZjkgSq8gWIW7aVijN9XhROYEXvkJ/9qvE6GRu3XbR9 D3cfJ/GreJmwT4KhEYL5Ka8jqCkbflBV+/7OHwms0Vymr6ke8/5hzHDGN7CeZGIQ5L DXtSyMNOt2CR416I2/qnr9ijveu78Lfykrhhp7jg= Date: Thu, 26 Aug 2021 12:07:38 +0200 From: Greg Kroah-Hartman To: Bryan Brattlof Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: rtl8723bs: remove sdio_osintf.h Message-ID: References: <20210823221156.3353972-1-hello@bryanbrattlof.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210823221156.3353972-1-hello@bryanbrattlof.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 10:12:21PM +0000, Bryan Brattlof wrote: > All definitions inside sdio_osintf.h are unused. Remove it. > > Signed-off-by: Bryan Brattlof > --- > drivers/staging/rtl8723bs/include/drv_types.h | 1 - > drivers/staging/rtl8723bs/include/sdio_osintf.h | 16 ---------------- > 2 files changed, 17 deletions(-) > delete mode 100644 drivers/staging/rtl8723bs/include/sdio_osintf.h > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h > index 580028d28c42..0e6741db95bf 100644 > --- a/drivers/staging/rtl8723bs/include/drv_types.h > +++ b/drivers/staging/rtl8723bs/include/drv_types.h > @@ -489,7 +489,6 @@ static inline u8 *myid(struct eeprom_priv *peepriv) > } > > /* HCI Related header file */ > -#include > #include > #include > > diff --git a/drivers/staging/rtl8723bs/include/sdio_osintf.h b/drivers/staging/rtl8723bs/include/sdio_osintf.h > deleted file mode 100644 > index 146b44f95e29..000000000000 > --- a/drivers/staging/rtl8723bs/include/sdio_osintf.h > +++ /dev/null > @@ -1,16 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > -/****************************************************************************** > - * > - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. > - * > - ******************************************************************************/ > -#ifndef __SDIO_OSINTF_H__ > -#define __SDIO_OSINTF_H__ > - > - > - > -u8 sd_hal_bus_init(struct adapter *padapter); > -u8 sd_hal_bus_deinit(struct adapter *padapter); > -void sd_c2h_hdl(struct adapter *padapter); What about the instances in drivers/staging/rtl8723bs/include/sdio_hal.h? Please remove them at the same time. thanks, greg k-h