From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF9EC4320A for ; Fri, 27 Aug 2021 07:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0E366101B for ; Fri, 27 Aug 2021 07:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244558AbhH0Hya (ORCPT ); Fri, 27 Aug 2021 03:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244554AbhH0Hy2 (ORCPT ); Fri, 27 Aug 2021 03:54:28 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FF7CC0613D9 for ; Fri, 27 Aug 2021 00:53:39 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id y34so12581871lfa.8 for ; Fri, 27 Aug 2021 00:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FnvhmoF5/z5/Vlkplzor1LntS+hajMMuv6rFjI/7vFw=; b=NRx5Wx6kgOUXMrIJ2SbxoHAdocMAaMe+q3x/PbhlpQ753+LbpjsX4my4xo/BNlbDWM X+RX+7MeLQZub1WWy3wOwIfyUBCpAbZQvpuhdBUXN9pXxAykoArZndCZm9D8+pWmD6/n Os+oiJRMwJNY5v2GRnZBb2+hfMehbUV4ZKEfzyixmfth71yaofaAu6svKhWW16AMrfvD 530Yg3AkQgpDOGcMdnwMnM1bH4VI87O8WaubWNe0QIZk4pJXXPsEVIF4IyK3PjMH3WeP DnthtUJdG/UqBsUTvv6IXRM+UMCy/BpuDqpRpmUddAvf9xzf2KLmfOjj+iR3Pu86IljA HebA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FnvhmoF5/z5/Vlkplzor1LntS+hajMMuv6rFjI/7vFw=; b=aezUW91/Xc7w4sAl6lmRHNIzPY9CVxhVY6+SrL5GK9xVn1bhzrgL6WFSWSTmD4wHiO qNUkbWryBOyoBbM76pJ98LMQs9rP9dFJ74HJRVhH+B2SPc8GFrw292WG7UnLxEpTtDNq 59vqTw0I3JSg/kXK7Pj305EmSoZYwOAafifFZe5RwU/OZH/PuenY/vZo0NoMyAkB1gWs eWaHly8CUsP1rC/AYaBucjHdO7/iCRtv3xMUlK6+kBLKSvQ9Lshj2qpGf9DSKCnl4V3P QW0Ojrdaw9EWNhSrcH/SrS7ASXxszdTrZZLQ5H2uZ8ff7G6KfrYc67SZ57BehLp16l8I OeMg== X-Gm-Message-State: AOAM532wanNSUyzoyPZExFSeEJg6cKwHR/yXSmCyfOVn4D+pArCvCYzc xk0oDjgrpByf3A8mURGGtQG4VXUw/doBow== X-Google-Smtp-Source: ABdhPJwZdfVkvJZoC4n948k+9nQxzZ9D3jLacRPvLtoGWBGZcLZ3Dp0V5XDuyUJdJv98SJ3r3qThog== X-Received: by 2002:a05:6512:3092:: with SMTP id z18mr5792558lfd.395.1630050817735; Fri, 27 Aug 2021 00:53:37 -0700 (PDT) Received: from localhost (h-46-59-88-219.A463.priv.bahnhof.se. [46.59.88.219]) by smtp.gmail.com with ESMTPSA id l13sm520144lfj.199.2021.08.27.00.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 00:53:37 -0700 (PDT) Date: Fri, 27 Aug 2021 09:53:36 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Rajendra Nayak , "Rafael J . Wysocki" , Kevin Hilman , Ulf Hansson , Len Brown , Pavel Machek , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM: domains: Fix domain attach for CONFIG_PM_OPP=n Message-ID: References: <4fb42fa1b76b38c6628f056cfd804bb5b4e74d99.1629818532.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4fb42fa1b76b38c6628f056cfd804bb5b4e74d99.1629818532.git.geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thanks for your work. On 2021-08-24 17:23:38 +0200, Geert Uytterhoeven wrote: > If CONFIG_PM_OPP=n, of_get_required_opp_performance_state() always > returns -EOPNOTSUPP, and all drivers for devices that are part of a PM > Domain fail to probe with: > > failed to set required performance state for power-domain foo: -95 > probe of bar failed with error -95 > > Fix this by treating -EOPNOTSUPP the same as -ENODEV. > > Fixes: c016baf7dc58e77a ("PM: domains: Add support for 'required-opps' to set default perf state") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index a10d740c4f2a1c28..7b197690e6442911 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2760,7 +2760,7 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, > > /* Set the default performance state */ > pstate = of_get_required_opp_performance_state(dev->of_node, index); > - if (pstate < 0 && pstate != -ENODEV) { > + if (pstate < 0 && pstate != -ENODEV && pstate != -EOPNOTSUPP) { > ret = pstate; > goto err; > } else if (pstate > 0) { > -- > 2.25.1 > -- Regards, Niklas Söderlund