From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4A0C432BE for ; Mon, 30 Aug 2021 00:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8833E6023F for ; Mon, 30 Aug 2021 00:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236138AbhH3ASY (ORCPT ); Sun, 29 Aug 2021 20:18:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbhH3ASX (ORCPT ); Sun, 29 Aug 2021 20:18:23 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA22AC061575 for ; Sun, 29 Aug 2021 17:17:30 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id u11-20020a17090adb4b00b00181668a56d6so8786428pjx.5 for ; Sun, 29 Aug 2021 17:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1C8C+Dt0oLk10qRVIxYYtd66IFLf4/1C2glrdJ31MD8=; b=iFH0zbbdgUX2fEKG40Tl+c93tjzRvQflDnMNFMogzcSQ5re8lTiOnuuxXs8820saj9 vUgsN1xBYOkhLZgm9pwfVEQrcvmb8lGgkJ+x3ZP5Bo/Ni7AWKXmweLVwH0J5+U3mmUCJ MqPEFQLuvrRaKDb1mbOnjNdQWVPKI1kNmaLiR6qrj/IT/kFf3k86Ia69srwOkpJPafUk +qupUduV4chBiwtdMGlkeoOITp7ltszFvkOYsWOC5xWMpb2pDEvxgH47I1N2Avf30CUd BeXo8ybEFOS9q4/DgDjMSZalnjhkokjMG9b8/l/IpTnBciXFbqyyI5ANOpoa5OeltE92 NoXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1C8C+Dt0oLk10qRVIxYYtd66IFLf4/1C2glrdJ31MD8=; b=dRW4JGvCLJTVFBaVeF5Ii1eeytczfib1KmERggRuM1NFExqfj0v057xULdyun0xzvP 4eLIzgwnUcUB4S7yudxAnkIrdjFiQrMaWSk/KgZo/hIMfagG6Xe5zQexJkMtLtT80lg5 8fiojXTFrG+K2xkXy4KqIk7D5aV0dxduu3DHzyB6c6shVKGGwGJdS3qRK9OJjRgMvJ4n cTccGnwWgoYheSiIkerSRsv0aUJQUo6M6RdZoctdCLiNQvulpgByRxkQgj3Gn0xQb1vM NNxpDXxY7ghbDprIlZnhkSjIIk8eF0CmFXq0iwfV6l6x5ziVO1ic8hlQmaYA+ejSkDq5 0a2w== X-Gm-Message-State: AOAM530Pplc3yHE/UX1IhR0PXXIBdiJ0gG0M1//GfF/eVkoGIG9Ak8U2 U5yeCKXhDbH7hOlsjZ2hLN+W0MUvkIw= X-Google-Smtp-Source: ABdhPJxW8hyMQxdYktUmqt/HledhXbUgfROqJ+CjKuW3GUK1y/DmNdOjCcBgckVsLIf9YPRjWpa64w== X-Received: by 2002:a17:90a:428f:: with SMTP id p15mr36525779pjg.75.1630282650265; Sun, 29 Aug 2021 17:17:30 -0700 (PDT) Received: from localhost (g163.222-224-165.ppp.wakwak.ne.jp. [222.224.165.163]) by smtp.gmail.com with ESMTPSA id s15sm8708332pfu.67.2021.08.29.17.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 17:17:29 -0700 (PDT) Date: Mon, 30 Aug 2021 09:17:27 +0900 From: Stafford Horne To: Joel Stanley Cc: openrisc@lists.librecores.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] openrisc/litex: Add liteeth support Message-ID: References: <20210826132946.3324593-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210826132946.3324593-1-joel@jms.id.au> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 26, 2021 at 10:59:43PM +0930, Joel Stanley wrote: > Hello Stafford, > > Here are some changes so that the openrisc kernel can boot with ethernet > support with the in-tree device tree. > > I have also updated the address of the serial device to match recent > litex. I realise this may keep changing, but it does make it easier to > test upstream kernels if the basics work. > > Joel Stanley (3): > openrisc/litex: Update uart address > openrisc/litex: Add ethernet device > openrisc/litex: Update defconfig > > arch/openrisc/boot/dts/or1klitex.dts | 13 ++++++++++-- > arch/openrisc/configs/or1klitex_defconfig | 26 ++++++++++++++--------- > 2 files changed, 27 insertions(+), 12 deletions(-) Hi, These all look fine to me. Note, I have just using the autogenerated .dts file created by the litex build, so I don't usually use this one other than for some basic testing. I know auto generated one has it's quirks but it does work. It's good to have these here though. I will queue these after the ehternet driver is queued. Are you planning me to queue the ethernet driver? Or will someone else be taking that in? -Stafford