mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Choinière, Vincent" <choiniere.vincent@hydroquebec.com>
To: "netdev-bot+sashiko@kernel.org" <netdev-bot+sashiko@kernel.org>,
	"przemyslaw.kitszel@intel.com" <przemyslaw.kitszel@intel.com>,
	"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>
Cc: "anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"aleksandr.loktionov@intel.com" <aleksandr.loktionov@intel.com>,
	"michal.kubiak@intel.com" <michal.kubiak@intel.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@kernel.org" <edumazet@kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH net] ice: fix Tx hang dump using stale tx_buf[0].skb
Date: Mon, 26 Oct 2026 13:36:57 +0000	[thread overview]
Message-ID: <YT4PR01MB647290C874F1270D6B581668FEE3612@YT4PR01MB647290.CANPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <179250185873.3135.10101707471960530546@kernel.org>


Thanks everyone for the review. I posted v2 here:

https://lore.kernel.org/netdev/20261026-ice-tx-hang-dump-v2-1-e2136ef2c5dc@hydroquebec.com/

Following Sashiko's feedback, v2 no longer dereferences the skb:
only its pointer value is reported. It also validates the saved ring
under RTNL before copying the descriptors and IRQ name, then releases
RTNL before calling devlink_health_report().

Przemek: thanks for the conditional Acked-by. Since the implementation
changed substantially beyond the additional NULL checks, I have not
carried it over. Could you take another look?

Paul: the skb contents are no longer included, but the descriptor
dump remains available when a ring snapshot can be taken. I dropped
your Reviewed-by because the implementation changed substantially.

Synchronization of tx_hang_buf between ice_tx_timeout() and the
service task remains outside this patch and is documented under
Limitations.

      reply	other threads:[~2026-10-26 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 13:08 Vincent Choiniere via B4 Relay
2026-10-16 16:56 ` Paul Menzel
2026-10-19 11:20 ` Przemek Kitszel
2026-10-20 13:10 ` netdev-bot+sashiko
2026-10-26 13:36   ` Choinière, Vincent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YT4PR01MB647290C874F1270D6B581668FEE3612@YT4PR01MB647290.CANPRD01.PROD.OUTLOOK.COM \
    --to=choiniere.vincent@hydroquebec.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.kubiak@intel.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®