From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] driver core: platform: Fix the line-break indentation
Date: Thu, 2 Sep 2021 07:37:12 +0200 [thread overview]
Message-ID: <YTBjCA6UcHDgVdCv@kroah.com> (raw)
In-Reply-To: <20210902052446.31839-1-caihuoqing@baidu.com>
On Thu, Sep 02, 2021 at 01:24:45PM +0800, Cai Huoqing wrote:
> Fix the line-break indentation for the helper function
> devm_platform_get_and_ioremap_resource()
Why? What is wrong with what is there today? You need to explain _why_
you do something, not just _what_ you did.
If you want to do basic coding style cleanups, please stick with
drivers/staging/
thanks,
greg k-h
prev parent reply other threads:[~2021-09-02 5:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 5:24 Cai Huoqing
2021-09-02 5:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTBjCA6UcHDgVdCv@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=caihuoqing@baidu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®