From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FAE4C4332F for ; Thu, 2 Sep 2021 20:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71596610A0 for ; Thu, 2 Sep 2021 20:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345335AbhIBUOh (ORCPT ); Thu, 2 Sep 2021 16:14:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345536AbhIBUOW (ORCPT ); Thu, 2 Sep 2021 16:14:22 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0817C061575 for ; Thu, 2 Sep 2021 13:13:23 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id t42so2526985pfg.12 for ; Thu, 02 Sep 2021 13:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CLRB1fmY18sRspCB9D7hr3FKnvNokdnWWOzE6+3PPlQ=; b=GmrNngoCk4V04BfxSA0bkXqg0TGLiQdCGNSwC670QeK+u8i3NrdmdCXYpRokKSweO0 yumzbdZ4MDej2pXYUcUHRH8wA2U3wnPuHLUDTNQ9KfNu0iSO2SXWLtKUn57y47gPML8M bIGl+e5zYvRxG97IP6R/k1SssxWUy7yXAQT6Dt7JaXtT0cEswmF3TOQpgU6KD9jX5Thf NohTcFr7AjYlqycsmzmtD5z/M7l+x2Z2FOalh1BpC2bt0erayx2Q9t3ydOYez7F06z/B 3sKhGwmWb/3jZ+YRbepbeZZoKYrBaw3uYVLvcFzA3287OXtcDYdZYU9UWDVTt2jEeSTy agow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CLRB1fmY18sRspCB9D7hr3FKnvNokdnWWOzE6+3PPlQ=; b=XGHL7V2gDLXmUBrIaC9cRGWaquEpo//EZ6W3uFzVZKge3SNDMBOUUWFuQC9Uh+fGKu 3eOR0oC9VnSTBDtLI8/nBlMMFgy8upjFBWvR4KaMHpymqpbXu+TdSTxT85HZzCYGpEBN BC810Ap9ZqLU/3/ydyRX3kJ0GyseJal3/EzEAMfVLPYiZ/uzDaxKHHallXgYsFo+hffk 5/n5VWGSvpcmbVgMoBtjyal3klIRkl68/mulgY49KJm2Jx3MYCJyop+/qmMbjPO+Zq+s KDjg5m0cz/hQQWeL07mvzHOCfC6EtPPP5OSuhWRevPgFRu+c8IwO3B8gGMBVAOFMomt0 WgEA== X-Gm-Message-State: AOAM531mZyBTXaNZ8a2iEmdWPGMGFw6d3ALI74TSuiAuqJ/mx5ZvabTF uMmiJM/bNeY51Mysp+7kS4dUFg== X-Google-Smtp-Source: ABdhPJyEAVRd+rq9AbELMXl8dUzDNh8MEn8lpzeau0IqxK3acWf20Q1OkhetryKYRYWDmaHvBo1p+w== X-Received: by 2002:a63:f62:: with SMTP id 34mr100328pgp.159.1630613603007; Thu, 02 Sep 2021 13:13:23 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id v20sm3663656pgi.39.2021.09.02.13.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 13:13:22 -0700 (PDT) Date: Thu, 2 Sep 2021 20:13:18 +0000 From: Sean Christopherson To: Peter Xu Cc: Vitaly Kuznetsov , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , kernel test robot Subject: Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested() Message-ID: References: <20210901230506.13362-1-peterx@redhat.com> <87y28flyxj.fsf@vitty.brq.redhat.com> <87r1e7lycp.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021, Peter Xu wrote: > On Thu, Sep 02, 2021 at 06:46:14PM +0200, Vitaly Kuznetsov wrote: > > Sean Christopherson writes: > > > > > On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote: > > >> Peter Xu writes: > > >> > > >> > Drop the unused function as reported by test bot. > > >> > > >> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in > > >> reallity you drop "kvm_dirty_gfn_invalid()". > > > > > > Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful > > > to reviewers to respond to your own patch if there's a fatal mistake and you're > > > going to immediately post a new version. For tiny patches it's not a big deal, > > > but for larger patches it can avoid wasting reviewers' time. > > > > > > > Indeed. It's also a good reminder for reviewers that inbox is best > > treated like a stack and not like a queue :-) > > It should really be a queue, to be fair. :) Ya, a queue plus a deferred work queue for things that can't be handled in interrupt context ;-)