From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BB6C433FE for ; Fri, 3 Sep 2021 07:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB0D360F92 for ; Fri, 3 Sep 2021 07:59:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348087AbhICIAS (ORCPT ); Fri, 3 Sep 2021 04:00:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231332AbhICIAR (ORCPT ); Fri, 3 Sep 2021 04:00:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 972CDC061575; Fri, 3 Sep 2021 00:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=quE3z4xC195VtvSPtHx4IVlWpjfXNxo5cVGhrWgtGhA=; b=bLHr+KMkw/ZxeQLvQXrOallvZ2 RdnoqBQe9yzJOg0DzvIYPWKnmBQh7Gzafji0+3Axmze3gmsPP3gpg2Ef6urXBfSiv1VpjqqMs0V4g QNh25dDfz6phJcDefu1NGDOixoKze1wHtATiGEabPTYxa2OrFXV1aYWw70xsiZ53rBwxqdg+O3eQO LbQ6WrqMU0lUExdOfw2pKmeM/NHt/G09gdYDKNQyxDZpvIeZev1gYv5onXXdZnClkb54ILTErR+UF SH6BF0Esp7GRCDGEibKBvSMaA8IsTLBRKFyW7xjmL41xeO49kaRcVUDkzoJ8kFGpH+Yt6mw4ndVWu YvH68rxA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM44R-004GLf-FA; Fri, 03 Sep 2021 07:57:27 +0000 Date: Fri, 3 Sep 2021 08:57:07 +0100 From: Christoph Hellwig To: James Bottomley Cc: Linus Torvalds , Jens Axboe , Andrew Morton , linux-scsi , linux-kernel , Christoph Hellwig Subject: Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window Message-ID: References: <26c12f13870a2276f41aebfea6e467d576f70860.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 03, 2021 at 05:27:26AM +0100, Christoph Hellwig wrote: > On Thu, Sep 02, 2021 at 04:23:43PM -0700, James Bottomley wrote: > > > > > > Just checking that was fine, and I notice how *many* places do that. > > > > > > Should the blk_execute_rq() function even take that "struct gendisk > > > *bd_disk" argument at all? > > No, it shouldn't. rq->rq_disk should go away and use rq->q->disk > instead. This has been on my TODO list, but didn't make the cut for > this merge window. Here is a quick draft of that: http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-remove-rq_disk