From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49CFC433F5 for ; Wed, 8 Sep 2021 22:37:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A699A60F5E for ; Wed, 8 Sep 2021 22:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244003AbhIHWin (ORCPT ); Wed, 8 Sep 2021 18:38:43 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:48436 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242689AbhIHWim (ORCPT ); Wed, 8 Sep 2021 18:38:42 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 33B7E883; Thu, 9 Sep 2021 00:37:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1631140652; bh=1bGvqSulJnZHe9TfBwp2sU+A8oEVgTU8e0GgVdcU/ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cef2d0qWc8/lv1lki7yGSBS6cZX5fhhyJWDWBDSt4oq6beKouAYBKJzPayLQxOM/9 31dAAad6plu2+pKQWCvzlYuR1nhBraJfy7JRu6F2fAajaiLYHoTaqPbXkjYu5HEMQk hNf/pqe830GoTcdoHx7+bjaYR3JlEeSM0ETYTP8E= Date: Thu, 9 Sep 2021 01:37:11 +0300 From: Laurent Pinchart To: Martin Kepplinger Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de, mchehab@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: imx: set a media_device bus_info string Message-ID: References: <20210908084746.243359-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210908084746.243359-1-martin.kepplinger@puri.sm> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, Thank you for the patch. On Wed, Sep 08, 2021 at 10:47:46AM +0200, Martin Kepplinger wrote: > some tools like v4l2-compliance let users select a media device based s/some/Some/ I'll fix then when applying the patch to my tree. > on the bus_info string which can be quite convenient. Use a unique > string for that. > > This also fixes the following v4l2-compliance warning: > warn: v4l2-test-media.cpp(52): empty bus_info > > Signed-off-by: Martin Kepplinger Reviewed-by: Laurent Pinchart > --- > drivers/staging/media/imx/imx-media-dev-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c > index d006e961d8f4..80b69a9a752c 100644 > --- a/drivers/staging/media/imx/imx-media-dev-common.c > +++ b/drivers/staging/media/imx/imx-media-dev-common.c > @@ -367,6 +367,8 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev, > imxmd->v4l2_dev.notify = imx_media_notify; > strscpy(imxmd->v4l2_dev.name, "imx-media", > sizeof(imxmd->v4l2_dev.name)); > + snprintf(imxmd->md.bus_info, sizeof(imxmd->md.bus_info), > + "platform:%s", dev_name(imxmd->md.dev)); > > media_device_init(&imxmd->md); > -- Regards, Laurent Pinchart