From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B321C433EF for ; Thu, 9 Sep 2021 10:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 527B66120C for ; Thu, 9 Sep 2021 10:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233353AbhIIKDG (ORCPT ); Thu, 9 Sep 2021 06:03:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:56748 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbhIIKDD (ORCPT ); Thu, 9 Sep 2021 06:03:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D7F3B611AD; Thu, 9 Sep 2021 10:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631181714; bh=/1f9r8n9WVDTH6/Q/V695DPtM4Oyh3rAnEy9HTpXCm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GaBNtYTxaCkbW00RDO9jLMx28TcPJ2arczOBGqvAa6l6vLBjt9nYPnTO8sf8d37j4 SqR3oQan0g82yJ1F90YPW1cK9o2jeW2+sKJ2HgIIXtkYm2NwSY4+Q7qzZs/zJHSpGF 7pdh/UB9TvVYOUn+xTSm5h4nduILlOBa1UXHgI5Q= Date: Thu, 9 Sep 2021 12:01:51 +0200 From: Greg KH To: Larry Finger Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: Remove conditionals CONFIG_88EU_{AP_MODE,P2P} Message-ID: References: <20210908050109.1279-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210908050109.1279-1-Larry.Finger@lwfinger.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 08, 2021 at 12:01:09AM -0500, Larry Finger wrote: > These two conditional compile symbols are explicitly defined. > As a result, their included code is always compiled. They could be > converted to Kconfig symbols; however, my experience with this driver > in a GitHub repo is that many users of the device have it built into > a SOC or SBC that they wish to use as an access point. As a result, > CONFIG_88EU_APMODE would need to be selected. Thus it should be built in. > > There have also been many users the wish to establish peer-to-peer > networks with this device. For this reason, I am also proposing that > CONFIG_88EU_P2P be automatically included. > > Signed-off-by: Larry Finger Makes sense. If this really does need to be split up in the future, it can be done better without all of this #ifdef mess in the .c files. thanks, greg k-h