From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2027DC433EF for ; Fri, 10 Sep 2021 22:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04C6D6120C for ; Fri, 10 Sep 2021 22:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234735AbhIJWHQ (ORCPT ); Fri, 10 Sep 2021 18:07:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:48810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231812AbhIJWHP (ORCPT ); Fri, 10 Sep 2021 18:07:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9EE29611F2; Fri, 10 Sep 2021 22:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631311563; bh=PEunPYJPwyTliF9xftaapcX30zPfNh/6RruZ8943MUk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=od7TVsPMqrC0NqamqwtHigYolDNHNwZE9AU0tyRFpyXZ/FN3PppvBozqJlX75QBxo kc45xKTEGYCHqbqjy2aA1GSqiYzEdCZ2A0RIWMbeRElzNg6/x/WP/hWoqu2o44Y9lw K6p8Xi7IHcUqLuWJO9IqQEXc64sjLOnOcoOMxYp7+JEFaYlz+A1ZvxqeG7uxnLl16A h5/EKPDC0NGjZVgDn8qkTebCtWKn/pA20rt2BEdeI45AyT+Ybjk05iO+By6EgCw15B sBolr54p1KKaZvSJeb4hg8v7lPzEvJlOn2kgSedwaGtIVOnPWy8KlCVhpHwcoOYXA2 YIUYWvWJj41fA== Date: Fri, 10 Sep 2021 15:06:02 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Zhang Yi , Jan Kara Subject: Re: [PATCH v2] f2fs: avoid attaching SB_ACTIVE flag during mount Message-ID: References: <20210901080621.110319-1-chao@kernel.org> <8756a722-3363-9033-4a5f-047e28af645c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8756a722-3363-9033-4a5f-047e28af645c@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04, Chao Yu wrote: > On 2021/9/4 8:17, Jaegeuk Kim wrote: > > I remember this gave a regression before? > > I have removed changes which bothers checkpoint disabling path, how > about testing this in dev-test branch for a while? Let me give it a try. > > BTW, any plan to porting checkpoint disabling testcases from android > into xfstest suit? No. > > Thanks, > > > > > On 09/01, Chao Yu wrote: > > > Quoted from [1] > > > > > > "I do remember that I've added this code back then because otherwise > > > orphan cleanup was losing updates to quota files. But you're right > > > that now I don't see how that could be happening and it would be nice > > > if we could get rid of this hack" > > > > > > [1] https://lore.kernel.org/linux-ext4/99cce8ca-e4a0-7301-840f-2ace67c551f3@huawei.com/T/#m04990cfbc4f44592421736b504afcc346b2a7c00 > > > > > > Related fix in ext4 by > > > commit 72ffb49a7b62 ("ext4: do not set SB_ACTIVE in ext4_orphan_cleanup()"). > > > > > > f2fs has the same hack implementation in > > > - f2fs_recover_orphan_inodes() > > > - f2fs_recover_fsync_data() > > > > > > Let's get rid of this hack as well in f2fs. > > > > > > Cc: Zhang Yi > > > Cc: Jan Kara > > > Acked-by: Jan Kara > > > Signed-off-by: Chao Yu > > > --- > > > v2: > > > - don't bother checkpoint disabling path > > > fs/f2fs/checkpoint.c | 3 --- > > > fs/f2fs/recovery.c | 8 ++------ > > > 2 files changed, 2 insertions(+), 9 deletions(-) > > > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > > index 83e9bc0f91ff..7d8803a4cbc2 100644 > > > --- a/fs/f2fs/checkpoint.c > > > +++ b/fs/f2fs/checkpoint.c > > > @@ -705,9 +705,6 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi) > > > } > > > #ifdef CONFIG_QUOTA > > > - /* Needed for iput() to work correctly and not trash data */ > > > - sbi->sb->s_flags |= SB_ACTIVE; > > > - > > > /* > > > * Turn on quotas which were not enabled for read-only mounts if > > > * filesystem has quota feature, so that they are updated correctly. > > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > > > index 04655511d7f5..706ddb3c95c0 100644 > > > --- a/fs/f2fs/recovery.c > > > +++ b/fs/f2fs/recovery.c > > > @@ -787,8 +787,6 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > > > } > > > #ifdef CONFIG_QUOTA > > > - /* Needed for iput() to work correctly and not trash data */ > > > - sbi->sb->s_flags |= SB_ACTIVE; > > > /* Turn on quotas so that they are updated correctly */ > > > quota_enabled = f2fs_enable_quota_files(sbi, s_flags & SB_RDONLY); > > > #endif > > > @@ -816,10 +814,8 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > > > err = recover_data(sbi, &inode_list, &tmp_inode_list, &dir_list); > > > if (!err) > > > f2fs_bug_on(sbi, !list_empty(&inode_list)); > > > - else { > > > - /* restore s_flags to let iput() trash data */ > > > - sbi->sb->s_flags = s_flags; > > > - } > > > + else > > > + f2fs_bug_on(sbi, sbi->sb->s_flags & SB_ACTIVE); > > > skip: > > > fix_curseg_write_pointer = !check_only || list_empty(&inode_list); > > > -- > > > 2.32.0