From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix perf_event_attr__fprintf() missing/dupl. fields
Date: Sat, 11 Sep 2021 15:58:47 -0300 [thread overview]
Message-ID: <YTz8Zy4K3u43nkrF@kernel.org> (raw)
In-Reply-To: <20210911120550.12203-1-adrian.hunter@intel.com>
Em Sat, Sep 11, 2021 at 03:05:50PM +0300, Adrian Hunter escreveu:
> Some fields are missing and text_poke is duplicated. Fix that up.
Thanks, applied.
- Arnaldo
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/util/perf_event_attr_fprintf.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> index 30481825515b..47b7531f51da 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -137,6 +137,9 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> PRINT_ATTRf(cgroup, p_unsigned);
> PRINT_ATTRf(text_poke, p_unsigned);
> PRINT_ATTRf(build_id, p_unsigned);
> + PRINT_ATTRf(inherit_thread, p_unsigned);
> + PRINT_ATTRf(remove_on_exec, p_unsigned);
> + PRINT_ATTRf(sigtrap, p_unsigned);
>
> PRINT_ATTRn("{ wakeup_events, wakeup_watermark }", wakeup_events, p_unsigned);
> PRINT_ATTRf(bp_type, p_unsigned);
> @@ -150,7 +153,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> PRINT_ATTRf(aux_watermark, p_unsigned);
> PRINT_ATTRf(sample_max_stack, p_unsigned);
> PRINT_ATTRf(aux_sample_size, p_unsigned);
> - PRINT_ATTRf(text_poke, p_unsigned);
> + PRINT_ATTRf(sig_data, p_unsigned);
>
> return ret;
> }
> --
> 2.17.1
--
- Arnaldo
prev parent reply other threads:[~2021-09-11 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 12:05 Adrian Hunter
2021-09-11 18:58 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTz8Zy4K3u43nkrF@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®