From: Christoph Hellwig <hch@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] smp: Wake ksoftirqd on PREEMPT_RT instead do_softirq().
Date: Sat, 25 Sep 2021 11:31:52 +0100 [thread overview]
Message-ID: <YU76mB5hzvw3xZRB@infradead.org> (raw)
In-Reply-To: <20210924094755.2m32pgqwrqw2cg2s@linutronix.de>
On Fri, Sep 24, 2021 at 11:47:55AM +0200, Sebastian Andrzej Siewior wrote:
> + if (local_softirq_pending()) {
> +
> + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) {
> + do_softirq();
> + } else {
> + struct task_struct *ksoftirqd = this_cpu_ksoftirqd();
> +
> + if (ksoftirqd && !task_is_running(ksoftirqd))
> + wake_up_process(ksoftirqd);
> + }
> + }
At a cosmetic level this looks pretty weird. Why the empty line inside
the indented block? Why the pointless negation instead of the obvious
more straightforward order?
next prev parent reply other threads:[~2021-09-25 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:47 Sebastian Andrzej Siewior
2021-09-25 10:31 ` Christoph Hellwig [this message]
2021-09-26 15:16 ` Thomas Gleixner
2021-09-27 7:38 ` [PATCH v2] " Sebastian Andrzej Siewior
2021-10-26 11:48 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU76mB5hzvw3xZRB@infradead.org \
--to=hch@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®