From: Christoph Hellwig <hch@infradead.org>
To: Hamza Mahfooz <someguy@effective-light.com>
Cc: linux-kernel@vger.kernel.org, Benjamin LaHaise <bcrl@kvack.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] aio: convert active_reqs into a hashtable
Date: Tue, 14 Sep 2021 12:45:24 +0100 [thread overview]
Message-ID: <YUCLVAJLtseHuYsW@infradead.org> (raw)
In-Reply-To: <20210914094625.171211-1-someguy@effective-light.com>
On Tue, Sep 14, 2021 at 05:46:25AM -0400, Hamza Mahfooz wrote:
> Commit 833f4154ed56 ("aio: fold lookup_kiocb() into its sole caller")
> suggests that, the fact that active_reqs is a linked-list means aio_kiocb
> lookups in io_cancel() are inefficient. So, to get faster lookups (on
> average) while maintaining similar insertion and deletion characteristics,
> turn active_reqs into a hashtable.
What workload cares about AIO cancellation performance?
next prev parent reply other threads:[~2021-09-14 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:46 Hamza Mahfooz
2021-09-14 11:45 ` Christoph Hellwig [this message]
[not found] <202109171539.NOLGFkzS-lkp@intel.com>
2021-09-19 9:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUCLVAJLtseHuYsW@infradead.org \
--to=hch@infradead.org \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=someguy@effective-light.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®