From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4679DC433FE for ; Thu, 16 Sep 2021 13:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2ABA560ED7 for ; Thu, 16 Sep 2021 13:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239834AbhIPNFI (ORCPT ); Thu, 16 Sep 2021 09:05:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44110 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239126AbhIPNFE (ORCPT ); Thu, 16 Sep 2021 09:05:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=8B+OSG6AvJiUOcpkuo1so2J3WnuBg527X2nenttNjoQ=; b=tbWQib1AOzPx+m/HjVbjSuSgUi Qxlvem8kHDl1TyqR2BDJ3v0G+DT9TAPKn6aLSsbMZjzTgYgt+MAVvaGZwt/ag13NgTiwnZiE+UMoU 2u52dsesIOKGU8Xl3sEv/8ymrNU61aUbYQe8+6R3J+c/eWXM+mF3AEPSmmwmxxn76678=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mQr3C-006uNJ-0a; Thu, 16 Sep 2021 15:03:38 +0200 Date: Thu, 16 Sep 2021 15:03:37 +0200 From: Andrew Lunn To: Claudiu Beznea Cc: nicolas.ferre@microchip.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: macb: add support for mii on rgmii Message-ID: References: <20210915064721.5530-1-claudiu.beznea@microchip.com> <20210915064721.5530-4-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210915064721.5530-4-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 09:47:21AM +0300, Claudiu Beznea wrote: > Cadence IP has option to enable MII support on RGMII interface. This > could be selected though bit 28 of network control register. This option > is not enabled on all the IP versions thus add a software capability to > be selected by the proper implementation of this IP. Hi Claudiu You are adding a feature without a user. That is generally not accepted. Could you please also extend one of the macb_config structs to make use of this? Thanks Andrew