From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A2DC433EF for ; Fri, 17 Sep 2021 14:29:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4851360EE2 for ; Fri, 17 Sep 2021 14:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242466AbhIQObO (ORCPT ); Fri, 17 Sep 2021 10:31:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:45602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242098AbhIQObL (ORCPT ); Fri, 17 Sep 2021 10:31:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 791666121F; Fri, 17 Sep 2021 14:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631888989; bh=iChfwsk0r2h/iddeJN+kXh26ykQyn4SHYy6tFcRnB3o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EdPzbA/8SxytD6u+xlAGXl4nOosROu1Vq5pFoNlDgQN3a+Fo/NCgdqi2WUnHkMN60 4jCZm/jmobyuCj8Ac4zbNyHSmnddf/gb1bwbegC6BX6wujqbCZw0HsC43So/ftIc+4 WuhGAgK1WKKfIbLnyVp4cNv2ZGDmUSYluEvNTsfI= Date: Fri, 17 Sep 2021 16:29:46 +0200 From: Greg Kroah-Hartman To: Tawah Peggy Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wlan-ng: cfg80211: Fix lines should not end with '('. Message-ID: References: <20210915192110.GA325036@peggy-InsydeH2O-EFI-BIOS> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210915192110.GA325036@peggy-InsydeH2O-EFI-BIOS> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 08:21:10PM +0100, Tawah Peggy wrote: > This patch fixes the checkpatch.pl warning; > CHECK:lines should not end with '('. > by replacing ieee80211_frequency_to_channel() > with ieee80211_freq_to_channel() Please properly cc: the needed people and mailing lists that the scripts/get_maintainer.pl tool tells you to. Also please work on your C knowledge some more before contributing to the kernel. The change you made here was obviously not tested and worst of all, not even built tested as it breaks the build. thanks, greg k-h