From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6948C433EF for ; Sun, 19 Sep 2021 09:24:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9331261212 for ; Sun, 19 Sep 2021 09:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237505AbhISJZy (ORCPT ); Sun, 19 Sep 2021 05:25:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:59336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237226AbhISJZw (ORCPT ); Sun, 19 Sep 2021 05:25:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5957061212; Sun, 19 Sep 2021 09:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632043468; bh=bSIZwIh5uthvdwZh1zrRqm4gzyWRwEiLJVqVSspJ50s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cb6HeccPyGESeX7Jom5I3x66ewqBZS6QNnOZi8DCZeG+NUBDUlAJCylPrVB0xZRg2 UHQSMsHUxl2uM+Epdiy+70MaQPei0CynByHe+aB0x1fZenDaVR0MIAN/DtPQJXfKcM FA8xNamRMuclK34Y1PvAPNe2fnjZXEvgMJ+reV40= Date: Sun, 19 Sep 2021 11:24:25 +0200 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Subject: Re: [PATCH 1/2] soc: export soc_device_to_device symbol Message-ID: References: <20210917175134.252882-1-krzysztof.kozlowski@canonical.com> <20210917175134.252882-2-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 19, 2021 at 11:12:29AM +0200, Krzysztof Kozlowski wrote: > On 18/09/2021 09:02, Greg Kroah-Hartman wrote: > > On Fri, Sep 17, 2021 at 07:51:33PM +0200, Krzysztof Kozlowski wrote: > >> In case if soc-bus drivers are modules soc_device_to_device() has to be > >> exported. Since it is trivial, export it as non-GPL. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> --- > >> drivers/base/soc.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/base/soc.c b/drivers/base/soc.c > >> index 0af5363a582c..ac8db303daa1 100644 > >> --- a/drivers/base/soc.c > >> +++ b/drivers/base/soc.c > >> @@ -41,6 +41,7 @@ struct device *soc_device_to_device(struct soc_device *soc_dev) > >> { > >> return &soc_dev->dev; > >> } > >> +EXPORT_SYMBOL(soc_device_to_device); > > > > I thought we were getting rid of the use of this function, why export it > > and not just fix it up instead? > > > > Or am I confused about some other soc device abuse... > > I was not aware of discussion about soc_device_to_device(). Thanks for > pointing out the issue. I googled a little and found previous talks: > https://lore.kernel.org/lkml/20191111052741.GB3176397@kroah.com/ > > I can easily get rid of soc_device_to_device() in my driver, so first > patch won't be needed. Wonderful, thanks for fixing that up. greg k-h