From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40435C433EF for ; Mon, 20 Sep 2021 10:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23A9160FED for ; Mon, 20 Sep 2021 10:34:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234004AbhITKfv (ORCPT ); Mon, 20 Sep 2021 06:35:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:56040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbhITKfu (ORCPT ); Mon, 20 Sep 2021 06:35:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6386360F3A; Mon, 20 Sep 2021 10:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632134063; bh=LfZYAn6EQhZA6F2F/DFBpPbHtCyDTeRyH9Is5A/P9Ro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GgMNk+1Q7noIVbEQGXW7gR93/rCIauY6JM0bpbshZiTFTjnIg0qjVISa+60Dia0PX LZgtMb6s89Q9CTeZhwQSLyzR1BHpF9CcZqi9ACeiR3FQsonML7scma0RcWsuxWWnkE hTLTaH+Qs3eXEU+LZS5brHhR4KppwTPJgByIA16Q= Date: Mon, 20 Sep 2021 12:34:21 +0200 From: Greg KH To: Phillip Potter Cc: Michael Straube , Larry.Finger@lwfinger.net, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] staging: r8188eu: remove unused functions from rtw_ap.c Message-ID: References: <20210919153659.20826-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 19, 2021 at 09:27:25PM +0100, Phillip Potter wrote: > On Sun, Sep 19, 2021 at 05:36:53PM +0200, Michael Straube wrote: > > This series removes all unused functions from rtw_ap.c. > > > > Michael Straube (6): > > staging: r8188eu: remove ap_sta_info_defer_update() > > staging: r8188eu: remove rtw_acl_add_sta() > > staging: r8188eu: remove rtw_acl_remove_sta() > > staging: r8188eu: remove rtw_ap_inform_ch_switch() > > staging: r8188eu: remove rtw_check_beacon_data() > > staging: r8188eu: remove rtw_set_macaddr_acl() > > > > drivers/staging/r8188eu/core/rtw_ap.c | 584 ----------------------- > > drivers/staging/r8188eu/include/rtw_ap.h | 6 - > > 2 files changed, 590 deletions(-) > > > > -- > > 2.33.0 > > > > Dear Michael, > > Looks good to me, built and tested here with no warnings and driver > working fine still. Many thanks. > > For all six patches: > Acked-by: Phillip Potter Nit, in the future, I need an email after that to have the tools pick it up automatically. It should have looked like: Acked-by: name thanks, greg k-h