From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499C4C433EF for ; Mon, 20 Sep 2021 14:23:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25C3061107 for ; Mon, 20 Sep 2021 14:23:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234435AbhITOY4 (ORCPT ); Mon, 20 Sep 2021 10:24:56 -0400 Received: from mga04.intel.com ([192.55.52.120]:53219 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbhITOYz (ORCPT ); Mon, 20 Sep 2021 10:24:55 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="221256296" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="221256296" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 07:23:21 -0700 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="473636452" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 07:23:18 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 6080F20397; Mon, 20 Sep 2021 17:23:16 +0300 (EEST) Date: Mon, 20 Sep 2021 17:23:16 +0300 From: Sakari Ailus To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Arnd Bergmann , Daniele Alessandrelli , Martina Krasteva , Jacopo Mondi , Paul Kocialkowski , Tianshu Qiu , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: i2c: select V4L2_ASYNC where needed Message-ID: References: <20210920095830.1259051-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920095830.1259051-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anrd, On Mon, Sep 20, 2021 at 11:58:24AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > I came across a link failure from randconfig builds: > > x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove': > ths8200.c:(.text+0x491): undefined reference to `v4l2_async_unregister_subdev' > x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe': > ths8200.c:(.text+0xe49): undefined reference to `v4l2_async_register_subdev' > x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_remove': > tw9910.c:(.text+0x467): undefined reference to `v4l2_async_unregister_subdev' > x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_probe': > tw9910.c:(.text+0x1123): undefined reference to `v4l2_async_register_subdev' > > These clearly lack a 'select' statement, but I don't know why > this started happening only now. I had a bit of a look around to find > other configs that have the same problem, but could not come up with > a reliable way and found nothing else through experimentation. > It is likely that other symbols like these exist that need an extra > select. > > Signed-off-by: Arnd Bergmann Probably this one: commit ff3cc65cadb5d7333fde557b38cbb60b3a6cf496 Author: Sakari Ailus Date: Fri Mar 5 18:38:39 2021 +0100 media: v4l: async, fwnode: Improve module organisation The V4L2 async framework is generally used with the V4L2 fwnode, which also depends on the former. There are a few exceptions but they are relatively few. At the same time there is a vast number of systems that need videodev module, but have no use for v4l2-async that's now part of videodev. In order to improve, split the v4l2-async into its own module. Selecting V4L2_FWNODE also selects V4L2_ASYNC. This also moves the initialisation of the debufs entries for async subdevs to loading of the v4l2-async module. The directory is named as "v4l2-async". Signed-off-by: Sakari Ailus Reviewed-by: Ezequiel Garcia Signed-off-by: Mauro Carvalho Chehab I think I must have missed some drivers using v4l2-async. Acked-by: Sakari Ailus -- Sakari Ailus