From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D961C433F5 for ; Mon, 20 Sep 2021 21:31:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CAF161166 for ; Mon, 20 Sep 2021 21:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242973AbhITVdG (ORCPT ); Mon, 20 Sep 2021 17:33:06 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48604 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231784AbhITVbE (ORCPT ); Mon, 20 Sep 2021 17:31:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OlkMXkh2s33OM0B7hD3sf+exmaErS91ze8eL+MBOpUs=; b=lLSQ/n2eZtJJQBQxqbUfL6Idza pecYvfsJ9tqE95+y202bnfcSUAW7Dg49qhm4iaVwBiOXLhDG4o+zixTqUWmE4UvZSyjk+HLd26G2m cvL7tJf6/jhzMStMzBl11oR20v2PacLsYomMPyW/G++TOEBKs3K9prIIzXW8z4fbYQt8=; Received: from cpc102334-sgyl38-2-0-cust884.18-2.cable.virginm.net ([92.233.91.117] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mSQqj-000eWz-DW; Mon, 20 Sep 2021 21:29:18 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 2A43ED0E9AC; Mon, 20 Sep 2021 22:29:18 +0100 (BST) Date: Mon, 20 Sep 2021 22:29:18 +0100 From: Mark Brown To: Peter Rosin Cc: =?iso-8859-1?Q?P=E9ter?= Ujfalusi , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Takashi Iwai , Liam Girdwood , Kirill Marinushkin Subject: Re: [PATCH] ASoC: pcm512x: Mend accesses to the I2S_1 and I2S_2 registers Message-ID: References: <2d221984-7a2e-7006-0f8a-ffb5f64ee885@axentia.se> <815cbba4-60d6-8d97-c483-146c2f7c3912@axentia.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ttkamqm76OfwgUpe" Content-Disposition: inline In-Reply-To: <815cbba4-60d6-8d97-c483-146c2f7c3912@axentia.se> X-Cookie: lisp, v.: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ttkamqm76OfwgUpe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 20, 2021 at 09:37:37PM +0200, Peter Rosin wrote: > compare if the update was needed at all. But marking volatile wasn't > enough. I also tried to set both a default and mark as volatile, > but it seems every read fails with -16 (EBUSY). I don't get why, to me > it almost feels like a regmap issue of some sort (probably the regmap > config is bad in some way), but I'm not fluent in regmap... Having a default for a volatile register isn't really a sensible configuration since the whole point with volatile registers is that they change underneath us, I'd not be surprised if we had some error checking code in there that was trying to tell you there was a problem though it does seem like it should at least be more verbose about it since returning -EBUSY isn't exactly helpful by itself. --Ttkamqm76OfwgUpe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFI/S0ACgkQJNaLcl1U h9ByPwf+IyJ6E5k6G/3fuo7gN/7fle2sFUihfDabf6PJ4A9Ie0udY+tJ3Uhrn3MN yErjkmqtG4/FHWW9peKpDZ6G5JKqzuJhhjLOENnonbTE27dPkrfqzZ7sSklocdYl xU6c9EHN/8JOaoe4pu0nFbYauHwlEYaRnD6B34lnHGvjJb4ruuz280qE79ddobQY 08e8SwRYjVrWFhNUP/gc+OlHScnH3GuL9sDIuaAYvL+g6NEusF8oTPVQjYuJItdq DayQfrZ7M9VaZsLAPMsdm8l7Q9ab+2liGpFWDxMq+8ZaEjs/cORX/EVjxtjz1Snc boO8iQg8HZ4H9sCo62fIq1mvADMzcw== =sL7d -----END PGP SIGNATURE----- --Ttkamqm76OfwgUpe--