From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cgroup: Make rebind_subsystems() disable v2 controllers all at once
Date: Mon, 20 Sep 2021 08:00:28 -1000 [thread overview]
Message-ID: <YUjMPK5IzG7V2MnB@slm.duckdns.org> (raw)
In-Reply-To: <20210918225308.23822-1-longman@redhat.com>
On Sat, Sep 18, 2021 at 06:53:08PM -0400, Waiman Long wrote:
...
> It was caused by the fact that rebind_subsystem() disables
> controllers to be rebound one by one. If more than one disabled
> controllers are originally from the default hierarchy, it means that
> cgroup_apply_control_disable() will be called multiple times for the
> same default hierarchy. A controller may be killed by css_kill() in
> the first round. In the second round, the killed controller may not be
> completely dead yet leading to the warning.
>
> To avoid this problem, we collect all the ssid's of controllers that
> needed to be disabled from the default hierarchy and then disable them
> in one go instead of one by one.
>
> Fixes: 334c3679ec4b ("cgroup: reimplement rebind_subsystems() using cgroup_apply_control() and friends")
> Signed-off-by: Waiman Long <longman@redhat.com>
Applied to cgroup/for-5.16.
Thanks.
--
tejun
prev parent reply other threads:[~2021-09-21 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 22:53 Waiman Long
2021-09-20 18:00 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUjMPK5IzG7V2MnB@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®