From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, acme@kernel.org, mingo@redhat.com,
kernel-team@fb.com, eranian@google.com,
Lucian Grijincu <lucian@fb.com>
Subject: Re: [PATCH] perf/core: fix userpage->time_enabled of inactive events
Date: Thu, 23 Sep 2021 12:13:30 +0200 [thread overview]
Message-ID: <YUxTSn82eIP/4IzO@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YUxSMqrJK/rKPZS3@hirez.programming.kicks-ass.net>
On Thu, Sep 23, 2021 at 12:08:50PM +0200, Peter Zijlstra wrote:
> On Tue, Sep 21, 2021 at 06:17:15PM -0700, Song Liu wrote:
> It's wrong because:
>
> - you should only do this for (is_active & EVENT_TIME)
Note I also didn't do that :/ I actually did, but then figured it wasn't
worth the effort/mess it creates.
next prev parent reply other threads:[~2021-09-23 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 1:17 Song Liu
2021-09-23 6:42 ` Song Liu
2021-09-23 10:08 ` Peter Zijlstra
2021-09-23 10:13 ` Peter Zijlstra [this message]
2021-09-23 17:47 ` Song Liu
2021-09-24 13:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUxTSn82eIP/4IzO@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucian@fb.com \
--cc=mingo@redhat.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®