From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Subject: Re: [PATCH v3 3/8] media: ipu3-imgu: Set valid initial format
Date: Thu, 7 Oct 2021 00:50:05 +0300 [thread overview]
Message-ID: <YV4aDZlJeKT2CnxT@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20211001112522.2839602-4-ribalda@chromium.org>
Hi Ricardo,
On Fri, Oct 01, 2021 at 11:25:17AM +0000, Ricardo Ribalda wrote:
> The initial format did not have a valid size.
>
> Fixes v4l2-compliance:
>
> fail: v4l2-test-formats.cpp(723): Video Output Multiplanar:
> TRY_FMT(G_FMT) != G_FMT
> test VIDIOC_TRY_FMT: FAIL
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/staging/media/ipu3/ipu3-v4l2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 38a2407645096..1813bb29e362b 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -1136,7 +1136,9 @@ static int imgu_v4l2_node_setup(struct imgu_device *imgu, unsigned int pipe,
> def_pix_fmt.height = def_bus_fmt.height;
> def_pix_fmt.field = def_bus_fmt.field;
> def_pix_fmt.num_planes = 1;
> - def_pix_fmt.plane_fmt[0].bytesperline = def_pix_fmt.width * 2;
> + def_pix_fmt.plane_fmt[0].bytesperline =
> + imgu_bytesperline(def_pix_fmt.width,
> + IMGU_ABI_FRAME_FORMAT_RAW_PACKED);
I thought this was for the CIO2 driver when reviewing it, because of the
subject at the time. ;-) The 2nd patch is very nice, thanks!
--
Sakari Ailus
next prev parent reply other threads:[~2021-10-06 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 11:25 [PATCH v3 0/8] media: ipu3 + i2c: Fix v4l2-compliance issues Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 1/8] media: ipu3-cio2 Check num_planes and sizes in queue_setup Ricardo Ribalda
2021-10-06 21:56 ` Sakari Ailus
2021-10-06 22:27 ` Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 2/8] media: ipu3-imgu: Refactor bytesperpixel calculation Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 3/8] media: ipu3-imgu: Set valid initial format Ricardo Ribalda
2021-10-06 21:50 ` Sakari Ailus [this message]
2021-10-01 11:25 ` [PATCH v3 4/8] media: ipu3-imgu: imgu_fmt: Handle properly try Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 5/8] media: ipu3-imgu: VIDIOC_QUERYCAP: Fix bus_info Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 6/8] media: dw9714: Add implementation for events Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 7/8] media: ov13858: " Ricardo Ribalda
2021-10-01 11:25 ` [PATCH v3 8/8] media: ov5670: " Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV4aDZlJeKT2CnxT@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®