From: Mark Brown <broonie@kernel.org>
To: Trevor Woerner <twoerner@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Chen-Yu Tsai <wens@csie.org>,
Peter Robinson <pbrobinson@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] rk3399-nanopi4.dtsi: enable sdmmc regulator on boot
Date: Thu, 7 Oct 2021 15:25:18 +0100 [thread overview]
Message-ID: <YV8DTqA/6XI9KZmK@sirena.org.uk> (raw)
In-Reply-To: <20211006160817.13808-1-twoerner@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
On Wed, Oct 06, 2021 at 12:08:17PM -0400, Trevor Woerner wrote:
> @@ -71,6 +71,7 @@ vcc3v0_sd: vcc3v0-sd {
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc0_pwr_h>;
> regulator-always-on;
> + regulator-boot-on;
This shouldn't be required for devices that can read their status, the
fact that it's always on should cause it to be powered up if it wasn't
already when applying constraints. I'm therefore confused as to what
this change is doing and there's probably something else going on here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-10-07 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 16:08 Trevor Woerner
2021-10-07 14:25 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV8DTqA/6XI9KZmK@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pbrobinson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=twoerner@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®