From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4975BC433EF for ; Thu, 7 Oct 2021 15:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 275436121F for ; Thu, 7 Oct 2021 15:29:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233467AbhJGPa5 (ORCPT ); Thu, 7 Oct 2021 11:30:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:20942 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbhJGPa4 (ORCPT ); Thu, 7 Oct 2021 11:30:56 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="226179253" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="226179253" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 08:28:47 -0700 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="560602099" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 08:28:44 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mYVK3-009ZkW-DK; Thu, 07 Oct 2021 18:28:39 +0300 Date: Thu, 7 Oct 2021 18:28:39 +0300 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Brendan Higgins , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-media@vger.kernel.org, "Rafael J. Wysocki" , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Andrew Morton , Miguel Ojeda Subject: Re: [PATCH v3 2/7] kernel.h: Split out container_of() and typeof_member() macros Message-ID: References: <20211007150339.28910-1-andriy.shevchenko@linux.intel.com> <20211007150339.28910-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 05:09:09PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 07, 2021 at 06:03:34PM +0300, Andy Shevchenko wrote: ... > Why did you touch kobject.h here? Because it uses it, but indirectly. Now we may include it directly. > It shouldn't have been needed to change for this commit. OK. I will split it to a separate change. Would it be okay? > Anyway, I really don't think this is all worth any more work at all, > as > I'm not going to be the one taking it... It's fine. There are more people in favour of this change anyway. Thanks for review! -- With Best Regards, Andy Shevchenko