From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E2BC433EF for ; Tue, 28 Sep 2021 09:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4DD660F44 for ; Tue, 28 Sep 2021 09:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239836AbhI1JKz (ORCPT ); Tue, 28 Sep 2021 05:10:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:48212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239795AbhI1JKy (ORCPT ); Tue, 28 Sep 2021 05:10:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DEEAC60FC2; Tue, 28 Sep 2021 09:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632820155; bh=1Vhte9Ro5QwLvH3RD7I8NX1g4Y5GHjQOuHyXqDB5SP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RiqHZJ56Bc8xwKRyjWd2VRc6QiAa7sRjm1CkEUTVcMIHDKRWw2iszX6r6mRPogcBB uqkRyMbgkovNzgH4FSOxKKyZClW+DdlTPv+9/naHJ98JmDFbA1i4q6YKDOzoj/FX16 FjgQvZ2xYhMalZlnB8jA/gLoDbHapX/dw6zJVZ7w= Date: Tue, 28 Sep 2021 11:09:12 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: Mauro Carvalho Chehab , linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata Message-ID: References: <0cc63f19506ea78d3a1c111774c97bbbc1a9a292.1632812219.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 08:49:10AM +0100, Lee Jones wrote: > On Tue, 28 Sep 2021, Greg Kroah-Hartman wrote: > > > On Tue, Sep 28, 2021 at 08:58:19AM +0200, Mauro Carvalho Chehab wrote: > > > There are lots of fields in struct hi6421_spmi_pmic that aren't > > > used. As a matter of fact, only regmap is needed. > > > > > > So, drop the struct as a whole, and just set the regmap as > > > the drvdata. > > > > > > Acked-by: Mark Brown > > > Acked-for-MFD-by: Lee Jones > > > Signed-off-by: Mauro Carvalho Chehab > > > > As everyone else acked this, any objection for me to just take this in > > my char-misc tree? > > > > Otherwise, whoever else want to take it: > > > > Acked-by: Greg Kroah-Hartman > > If you do end up taking it, you'll have to convert my Ack. > > Although, I'm probably in a better position to take it TBH. > > Happy with either. You decide. You can take it, thanks! greg k-h