From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@microchip.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
macro@orcam.me.uk, zev@bewilderbeest.net, vigneshr@ti.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 0/3] serial:8250:Add driver support for MCHP PCI1XXXX UART module
Date: Wed, 29 Sep 2021 19:48:48 +0300 [thread overview]
Message-ID: <YVSY8L6A6H71DvM5@smile.fi.intel.com> (raw)
In-Reply-To: <20210929113049.64557-1-LakshmiPraveen.Kopparthi@microchip.com>
On Wed, Sep 29, 2021 at 05:00:46PM +0530, LakshmiPraveen Kopparthi wrote:
> PCI1XXXX UART is a PCIe to UART module. It has 5 SKUs, each is
> differentiated by the device IDs in the PCIe config space. Each
> SKU supports a maximum of 4 UART ports(UART0,1,2,3) with fixed
> offests.Based on the sub device ID, the combinations of UART
> ports shall be enumerated.
>
> The UART port is compatible with the standard 16550A, but has some
> modifications.The modifications includes a change in the baud rate
> settings,auto control of RTS signal for RS485 feature and an
> increase of TX & RX FIFO size to 256 Bytes.Also, it has a capability
> to wake up the CPU.
>
> These patches adds the support to enumerate and exercise all the
> combinations of UART ports in all the SKUs.
> drivers/tty/serial/8250/8250_pci.c | 384 ++++++++++++++++++++++++++++
Please, do not add this to 8250_pci.c. Use separate quirk driver as it's done
in plenty of examples:
8250_lpss.c, 8250_mid.c, 8250_exar.c, ...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-09-29 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 11:30 LakshmiPraveen Kopparthi
2021-09-29 11:30 ` [PATCH v1 1/3] serial:8250:Add basic driver support for MCHP PCI1XXXX UART LakshmiPraveen Kopparthi
2021-09-29 11:30 ` [PATCH v1 2/3] serial:8250:Add RS485 " LakshmiPraveen Kopparthi
2021-09-29 11:30 ` [PATCH v1 3/3] serial:8250: Add non standard baudrate " LakshmiPraveen Kopparthi
2021-09-29 16:48 ` Andy Shevchenko [this message]
2021-10-05 8:48 ` [PATCH v1 0/3] serial:8250:Add driver support for MCHP PCI1XXXX UART module LakshmiPraveen Kopparthi
2021-10-05 9:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVSY8L6A6H71DvM5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=LakshmiPraveen.Kopparthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=vigneshr@ti.com \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome