From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Cai Huoqing <caihuoqing@baidu.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Vadim Pasternak <vadimp@mellanox.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v2 1/1] infiniband: hf1: Use string_upper() instead of open coded variant
Date: Fri, 1 Oct 2021 16:48:49 +0300 [thread overview]
Message-ID: <YVcRwS+MZxMkpk8E@smile.fi.intel.com> (raw)
In-Reply-To: <256e577b57eb21555de96846d1ac4cfa3b8ee238.camel@perches.com>
On Fri, Oct 01, 2021 at 06:31:21AM -0700, Joe Perches wrote:
> On Fri, 2021-10-01 at 15:31 +0300, Andy Shevchenko wrote:
> > Use string_upper() from string helper module instead of open coded variant.
>
> Perhaps these string_upper and string_lower utility functions
> should return dst not void so these functions could be used in
> output calls.
Perhaps.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-01 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:31 Andy Shevchenko
2021-10-01 13:31 ` Joe Perches
2021-10-01 13:48 ` Andy Shevchenko [this message]
2021-10-05 18:23 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVcRwS+MZxMkpk8E@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=caihuoqing@baidu.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®