mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Böszörményi Zoltán" <zboszor@gmail.com>
Cc: zboszor@pr.hu, Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andy@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl-intel: Fix NULL pointer dereference
Date: Fri, 1 Oct 2021 21:11:45 +0300	[thread overview]
Message-ID: <YVdPYQ3RsyrWXU2H@smile.fi.intel.com> (raw)
In-Reply-To: <7f8ad14e-b2d8-676c-cd86-6ddd2dc386bb@gmail.com>

On Tue, Sep 21, 2021 at 07:07:17AM +0200, Böszörményi Zoltán wrote:
> On 2021. 09. 20. 18:00, Andy Shevchenko wrote:
> > On Mon, Sep 20, 2021 at 4:00 PM <zboszor@pr.hu> wrote:
> > > On an Elkhart Lake based POS hardware prototype, I got this Oops:

...

> > > It's probably a firmware bug, so be overly protective:
> > Patch is simply wrong. While Oops will be gone, the driver won't work correctly.
> 
> Of course. But a driver that gives up is better than a
> crashing kernel which results in udevd and "udevadm settle"
> stalling forever on it. systemd waits about 6 minutes before
> continuing the boot process that involves these two services
> timing out and this also prevents powering the computer down.

Hiding real bugs is not a good strategy. What you may do is blacklisting it.

> > Yes, it's either a firmware bug or the driver is outdated (depends
> > from which side you look at this issue).
> > 
> > I have heard that new firmware is on its way to the customers, but I
> > have no more information right now.
> 
> Thanks, good to know.
> 
> I also reported it to the manufacturer, I hope to receive
> a response from them soon.
> 
> The kernel reports other firmware bugs for this
> Celeron J6412 based machine.

Yeah...

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2021-10-01 18:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 12:44 zboszor
2021-09-20 16:00 ` Andy Shevchenko
     [not found]   ` <7f8ad14e-b2d8-676c-cd86-6ddd2dc386bb@gmail.com>
2021-10-01 18:11     ` Andy Shevchenko [this message]
2021-10-02  4:14       ` Böszörményi Zoltán

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVdPYQ3RsyrWXU2H@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=zboszor@gmail.com \
    --cc=zboszor@pr.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome