From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3442FC4332F for ; Tue, 5 Oct 2021 15:56:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14FC961166 for ; Tue, 5 Oct 2021 15:56:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235915AbhJEP6m (ORCPT ); Tue, 5 Oct 2021 11:58:42 -0400 Received: from www.zeus03.de ([194.117.254.33]:59464 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231513AbhJEP6j (ORCPT ); Tue, 5 Oct 2021 11:58:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=FJS7SPvRvF3PdPjZSbpmIydWilie fMdIsZln6Wmnq3k=; b=R2+eL99TBC+Q4iA1cEl90W14Y8DmRpQmcCWYYknL2u70 hwDZ0eIBlFnd3oHpmObK8pQDwPbmelJ/VwYAJK6fF0+aEEEww+q4hVx2RIz/22Z2 ZrVUSk/bRN7CZNoqggjTCoaBd/r4QDNu4afzYa+dMobDma4S2tmAL+4irWuOnvw= Received: (qmail 3867808 invoked from network); 5 Oct 2021 17:56:46 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 5 Oct 2021 17:56:46 +0200 X-UD-Smtp-Session: l3s3148p1@yIqhE53NZosgAwDPXw1kABtQsg8UzxVo Date: Tue, 5 Oct 2021 17:56:46 +0200 From: Wolfram Sang To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , Lad Prabhakar , Sergey Shtylyov , Philipp Zabel , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory: RENESAS_RPCIF should select RESET_CONTROLLER Message-ID: Mail-Followup-To: Wolfram Sang , Geert Uytterhoeven , Krzysztof Kozlowski , Lad Prabhakar , Sergey Shtylyov , Philipp Zabel , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5qWqAgTZuFQeFEgJ" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5qWqAgTZuFQeFEgJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2021 at 05:23:02PM +0200, Geert Uytterhoeven wrote: > The Renesas RPC-IF driver calls devm_reset_control_get_exclusive(), > which returns -ENOTSUPP if CONFIG_RESET_CONTROLLER is not enabled. > Even if this error is ignored, later calls to reset_control_reset() will > fail with a scary WARN_ON() backtrace. >=20 > Signed-off-by: Geert Uytterhoeven Yes, it is required. With the latter paragraph in the commit message removed: Reviewed-by: Wolfram Sang --5qWqAgTZuFQeFEgJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmFcdboACgkQFA3kzBSg KbalLhAAsBLI1H6ydrMltgltKwq5sdezuKDBDfB09gNwCkQeTUIQDSwzhgSk1pDp 1Sw8Dot8JWbUXDBZJ7HJJsZLU/tQtS/uIzzjQZkouax2j2QnW/7LaNtcEOkoi3Pt 0RLFDrO/SUStqETLP1z5e0JnW8Waiws4nPeR7jmymTNX0DqxsTtDF3fekhrx1BGE PlVKOo9a/zeOPLSK8kX7Z9coMPk5e/dGH/xZ0rukk6HBnZbRlwQcXZfFgNn+2rF+ dhYUV3AGSW2U0FHU6O7hZ8Ep5XY9F5YIhdoHBnrxSfn6kZRwQ7sVfcdiqqGjpNvA 2nMtFK8dXTZW1b6re9v16GaqqOBnqha1dTSIz0QqFufytpn+dYGy2jRYk87CaJ+Q BdMQjKU+qN4x8XwkP5kwkR2Tni+FJNyFXE55OG3r2nXas9srwCoGvUvmf+71lUlj 2YXvuIHFa7yYPt4LSGk0n/NRJbdff2twTpzpkdtGMJ6QKS29+ElKgwlYQ3jIzIIo Q7GZ7OtNSnuzoN6cs19EboRteq0vtr6I2lSJpmsqkljqfzalPB8YySPTcOGhkAze 2DAQfKLyF3twnuP6IkOtoIveg9+xJAqJjendXjGDrPT7xYNkrqhdtZUl7LlG18nv KglT2ZQ38KgBrV4+7fBgOxuZKGlDk5gFHrH6OxsWgrKeXYtolvs= =wDgE -----END PGP SIGNATURE----- --5qWqAgTZuFQeFEgJ--