From: Christoph Hellwig <hch@infradead.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: schedule queue restart after BLK_STS_ZONE_RESOURCE
Date: Tue, 19 Oct 2021 23:08:10 -0700 [thread overview]
Message-ID: <YW+ySp6Fqgxr8alD@infradead.org> (raw)
In-Reply-To: <20211020040404.132984-1-naohiro.aota@wdc.com>
On Wed, Oct 20, 2021 at 01:04:04PM +0900, Naohiro Aota wrote:
> needs_restart = blk_mq_sched_needs_restart(hctx);
> + need_resource |= (prep == PREP_DISPATCH_NO_BUDGET);
Nit: I think this would be a little more readable as:
if (prep == PREP_DISPATCH_NO_BUDGET)
need_resource = true;
But otherwise the patch looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-10-20 6:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 4:04 Naohiro Aota
2021-10-20 6:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW+ySp6Fqgxr8alD@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®