From: Johan Hovold <johan@kernel.org>
To: Wang Hai <wanghai38@huawei.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] USB: serial: Fix possible memleak in keyspan_port_probe()
Date: Mon, 18 Oct 2021 09:57:18 +0200 [thread overview]
Message-ID: <YW0o3hv6mG+NQ3f5@hovoldconsulting.com> (raw)
In-Reply-To: <20211015085543.1203011-1-wanghai38@huawei.com>
On Fri, Oct 15, 2021 at 04:55:43PM +0800, Wang Hai wrote:
> I got memory leak as follows when doing fault injection test:
>
> unreferenced object 0xffff888258228440 (size 64):
> comm "kworker/7:2", pid 2005, jiffies 4294989509 (age 824.540s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff8167939c>] slab_post_alloc_hook+0x9c/0x490
> [<ffffffff8167f627>] kmem_cache_alloc_trace+0x1f7/0x470
> [<ffffffffa02ac0e4>] keyspan_port_probe+0xa4/0x5d0 [keyspan]
> [<ffffffffa0294c07>] usb_serial_device_probe+0x97/0x1d0 [usbserial]
> [<ffffffff82b50ca7>] really_probe+0x167/0x460
> [<ffffffff82b51099>] __driver_probe_device+0xf9/0x180
> [<ffffffff82b51173>] driver_probe_device+0x53/0x130
> [<ffffffff82b516f5>] __device_attach_driver+0x105/0x130
> [<ffffffff82b4cfe9>] bus_for_each_drv+0x129/0x190
> [<ffffffff82b50a69>] __device_attach+0x1c9/0x270
> [<ffffffff82b518d0>] device_initial_probe+0x20/0x30
> [<ffffffff82b4f062>] bus_probe_device+0x142/0x160
> [<ffffffff82b4a4e9>] device_add+0x829/0x1300
> [<ffffffffa0295fda>] usb_serial_probe.cold+0xc9b/0x14ac [usbserial]
> [<ffffffffa02266aa>] usb_probe_interface+0x1aa/0x3c0 [usbcore]
> [<ffffffff82b50ca7>] really_probe+0x167/0x460
>
> If it fails to allocate memory for an out_buffer[i] or in_buffer[i],
> the previously allocated memory for out_buffer or in_buffer needs to
> be freed on the error handling path, otherwise a memory leak will result.
>
> Fixes: bad41a5bf177 ("USB: keyspan: fix port DMA-buffer allocations")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> v1->v2: rename error labels
Thanks for the update. Now applied with a slightly amended commit
message:
USB: serial: keyspan: fix memleak on probe errors
...
If keyspan_port_probe() fails...
Johan
prev parent reply other threads:[~2021-10-18 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 8:55 Wang Hai
2021-10-18 7:57 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW0o3hv6mG+NQ3f5@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®