From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E79E9C433F5 for ; Mon, 18 Oct 2021 19:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0F5F61283 for ; Mon, 18 Oct 2021 19:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbhJRTFJ (ORCPT ); Mon, 18 Oct 2021 15:05:09 -0400 Received: from mga04.intel.com ([192.55.52.120]:22880 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231234AbhJRTFI (ORCPT ); Mon, 18 Oct 2021 15:05:08 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="227111594" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="227111594" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 12:02:27 -0700 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="566192249" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.159]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 12:02:23 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mcXtc-000IvV-Jz; Mon, 18 Oct 2021 22:02:04 +0300 Date: Mon, 18 Oct 2021 22:02:04 +0300 From: Andy Shevchenko To: Maxim Levitsky Cc: Hans de Goede , linux-realtek-soc@lists.infradead.org, Oder Chiou , Ping-Ke Shih , nic_swsd@realtek.com, Derek Fang , Hayes Wang , Kailang Yang , linux-iio , Lars-Peter Clausen , LKML , info@ayaneo.com Subject: Re: BMI160 accelerometer on AyaNeo tablet Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 09:02:40PM +0300, Maxim Levitsky wrote: > I also suspect a mistake from the hardware vendors. > > I attached all DSDT decompiled, which shows that they indeed use that > ID, and I also attached the windows driver .INF which was published on > their website with the driver (https://www.ayaneo.com/downloads) > > They are a small startup so they might have used the realtek ID by mistake. > I added them to the CC. Thank you for sharing. Seems they indeed used (deliberately or not) the wrong ID. So there are questions I have: - Is the firmware available in the wild? - Do they plan to update firmware to fix this? - Can we make sure that guys got their mistake and will be more careful in the future? Realtek probably should make this ID marked somehow broken and not use in their products in case the answer to the first of the above question is "yes". (Of course in case the ID will be used for solely PCI enumerated product there will be no conflict, I just propose to be on the safest side, but remark should be made somewhere). > BTW, I also notice a rotation matrix embedded in DSTD, but the linux's > BMI160 driver doesn't recognize it. This is done by the commit 8a0672003421 ("iio: accel: bmc150: Get mount-matrix from ACPI") which needs to be amended to take care about more devices, somewhere in drivers/iio/industialio-acpi.c ? Jonathan, Hans, what do you think? P.S. As I said, the commit message and the code (in the comments) should be very well elaborated and only accepted in case the firmware is already in the wild on the market. -- With Best Regards, Andy Shevchenko