From: Greg KH <gregkh@linuxfoundation.org>
To: cgel.zte@gmail.com
Cc: arve@android.com, tkjos@android.com, maco@android.com,
joel@joelfernandes.org, christian@brauner.io, hridya@google.com,
surenb@google.com, linux-kernel@vger.kernel.org,
Ran Jianping <ran.jianping@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH binder] binder: remove duplicate include in binder.c
Date: Tue, 19 Oct 2021 11:12:24 +0200 [thread overview]
Message-ID: <YW6L+LkxamhGLwmt@kroah.com> (raw)
In-Reply-To: <20211019080402.993974-1-ran.jianping@zte.com.cn>
On Tue, Oct 19, 2021 at 08:04:02AM +0000, cgel.zte@gmail.com wrote:
> From: Ran Jianping <ran.jianping@zte.com.cn>
>
> 'binder_trace.h' included in 'drivers/android/binder.c'
> is duplicated.It is also included on the 6026 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ran Jianping <ran.jianping@zte.com.cn>
> ---
> drivers/android/binder.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 26382e982c5e..19f6247d33f5 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6023,6 +6023,5 @@ static int __init binder_init(void)
> device_initcall(binder_init);
>
> #define CREATE_TRACE_POINTS
> -#include "binder_trace.h"
>
> MODULE_LICENSE("GPL v2");
> --
> 2.25.1
>
Did you build this code after making this change and verify that the
tracepoints still work properly?
Please fix your "robot", it is broken.
greg k-h
next prev parent reply other threads:[~2021-10-19 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 8:04 cgel.zte
2021-10-19 9:12 ` Greg KH [this message]
2021-10-19 22:51 ` kernel test robot
2021-10-24 14:02 ` kernel test robot
2021-10-25 0:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW6L+LkxamhGLwmt@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=cgel.zte@gmail.com \
--cc=christian@brauner.io \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=ran.jianping@zte.com.cn \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®