From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: axboe@kernel.dk, paolo.valente@linaro.org,
avanzini.arianna@gmail.com, fchecconi@gmail.com,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH v3 -next 2/2] blk-cgroup: synchoronize blkg creation against policy deactivation
Date: Tue, 19 Oct 2021 07:03:13 -1000 [thread overview]
Message-ID: <YW76UThK20WaCWO6@slm.duckdns.org> (raw)
In-Reply-To: <20211019024132.432458-3-yukuai3@huawei.com>
Hello,
Some nitpicks.
On Tue, Oct 19, 2021 at 10:41:32AM +0800, Yu Kuai wrote:
...
> Because blkcg_deactivate_policy() require queue to be freezed, thus grab
^ ^ ^
requires frozen we can grab
> q_usage_counter to synchoronize blkg_conf_prep() against
> blkcg_deactivate_policy().
...
> + /*
> + * blkcg_deactivate_policy() require queue to be freezed, thus grab
> + * q_usage_counter to prevent concurrent with blkcg_deactivate_policy().
> + */
Same here.
Looks good otherwise. Please feel free to add
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2021-10-19 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 2:41 [PATCH v3 -next 0/2] " Yu Kuai
2021-10-19 2:41 ` [PATCH v3 -next 1/2] blk-cgroup: don't call blk_mq_freeze_queue() in blkcg_deactivate_policy() Yu Kuai
2021-10-19 17:00 ` Tejun Heo
2021-10-19 2:41 ` [PATCH v3 -next 2/2] blk-cgroup: synchoronize blkg creation against policy deactivation Yu Kuai
2021-10-19 17:03 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW76UThK20WaCWO6@slm.duckdns.org \
--to=tj@kernel.org \
--cc=avanzini.arianna@gmail.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=fchecconi@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®