From: Mark Brown <broonie@kernel.org>
To: cy_huang <u0084500@gmail.com>
Cc: oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
robh+dt@kernel.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
cy_huang@richtek.com, devicetree@vger.kernel.org,
allen_lin@richtek.com
Subject: Re: [PATCH v3 2/2] ASoC: rt9120: Add rt9210 audio amplifier support
Date: Fri, 8 Oct 2021 13:51:22 +0100 [thread overview]
Message-ID: <YWA+ykStTEyzRbEy@sirena.org.uk> (raw)
In-Reply-To: <1633668612-25524-3-git-send-email-u0084500@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On Fri, Oct 08, 2021 at 12:50:12PM +0800, cy_huang wrote:
> +static const struct snd_kcontrol_new rt9120_snd_controls[] = {
> + SOC_SINGLE_TLV("MS Volume", RT9120_REG_MSVOL, 0, 2047, 1, digital_gain),
> + SOC_SINGLE("SPK Gain", RT9120_REG_SPKGAIN, 0, 7, 0),
Volume controls should end in Volume even if they don't have TLV
information so applications know how to render them. I'll fix
this up as I apply.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-08 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 4:50 [PATCH v3 0/2] ASoC: rt9120: Add Richtek RT9120 supprot cy_huang
2021-10-08 4:50 ` [PATCH v3 1/2] ASoC: dt-bindings: rt9120: Add initial bindings cy_huang
2021-10-08 4:50 ` [PATCH v3 2/2] ASoC: rt9120: Add rt9210 audio amplifier support cy_huang
2021-10-08 12:51 ` Mark Brown [this message]
2021-10-12 2:47 ` ChiYuan Huang
2021-10-12 3:07 ` ChiYuan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWA+ykStTEyzRbEy@sirena.org.uk \
--to=broonie@kernel.org \
--cc=allen_lin@richtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®