From: Sakari Ailus <sakari.ailus@iki.fi>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Matteo Lisi <matteo.lisi@engicam.com>
Subject: Re: [PATCH v5] Driver for ON Semi AR0521 camera sensor
Date: Tue, 12 Oct 2021 23:30:00 +0300 [thread overview]
Message-ID: <YWXwSAm3OO/WTkOL@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <m3a6jel9ce.fsf@t19.piap.pl>
Hi Krzysztof,
On Tue, Oct 12, 2021 at 02:24:17PM +0200, Krzysztof Hałasa wrote:
> Jacopo,
>
> > I'll pretend I haven't read this not to be dragged in tangential
> > discussions. My whole point was such a commit message is useless as I
> > assume if you submit a driver for inclusion you have tested it.
>
> Fine, I will remove that very commit comment.
>
> > I think the clock rate should be assigned in DTS and you should verify
> > it falls in the supported clock ranges.
>
> Which driver does that, please?
> clk_set_rate() appears to be used by multiple drivers, I was thinking
> I can use it.
> I can see clock frequencies in DTS, but they usually refer to fixed
> clocks (e.g. crystal-based). The clock I use is IMX6QDL_CLK_CKO, some
> sort of a shared generic clock from inside of the CPU. I don't know if
> I could even set its frequency in DTS.
Please see:
https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html
Generally camera sensor drivers that set the clock in drivers themselves
are (very) old.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2021-10-12 20:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 12:05 Krzysztof Hałasa
2021-10-06 17:10 ` Sakari Ailus
2021-10-07 9:11 ` Krzysztof Hałasa
2021-10-09 9:07 ` Jacopo Mondi
2021-10-09 20:18 ` Randy Dunlap
2021-10-09 20:34 ` Sakari Ailus
2021-10-11 6:24 ` Krzysztof Hałasa
2021-10-11 6:20 ` Krzysztof Hałasa
2021-10-11 6:31 ` Laurent Pinchart
2021-10-12 7:52 ` Krzysztof Hałasa
2021-10-09 10:24 ` Jacopo Mondi
2021-10-11 12:19 ` Krzysztof Hałasa
2021-10-11 14:34 ` Jacopo Mondi
2021-10-11 22:22 ` Daniel Scally
2021-10-12 7:16 ` Jacopo Mondi
2021-10-12 12:24 ` Krzysztof Hałasa
2021-10-12 20:30 ` Sakari Ailus [this message]
2021-10-13 5:39 ` Krzysztof Hałasa
2021-10-20 18:43 ` Sakari Ailus
2021-10-22 6:42 ` Krzysztof Hałasa
2021-10-13 8:26 ` Jacopo Mondi
2021-10-13 12:55 ` Krzysztof Hałasa
2021-10-13 15:14 ` Jacopo Mondi
2021-10-14 5:43 ` Krzysztof Hałasa
2021-10-14 7:59 ` Jacopo Mondi
2021-10-14 10:43 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWXwSAm3OO/WTkOL@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=jacopo@jmondi.org \
--cc=khalasa@piap.pl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matteo.lisi@engicam.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®