From: Tzung-Bi Shih <tzungbi@google.com>
To: Fei Shao <fshao@chromium.org>
Cc: Jassi Brar <jaswinder.singh@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"jason-jh.lin" <jason-jh.lin@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/2] mailbox: mtk-cmdq: Fix local clock ID usage
Date: Thu, 14 Oct 2021 23:55:02 +0800 [thread overview]
Message-ID: <YWhS1qkwqkmwAyi8@google.com> (raw)
In-Reply-To: <20211014120352.1506321-3-fshao@chromium.org>
On Thu, Oct 14, 2021 at 08:03:52PM +0800, Fei Shao wrote:
> In the probe function, the clock IDs were pointed to local variables
> which should only be used in the same code block, and any access to them
> after the probing stage becomes an use-after-free case.
>
> Since there are only limited variants of the gce clock names so far, we
> can just declare them as static constants to fix the issue.
>
> Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for
> mt8195")
> Signed-off-by: Fei Shao <fshao@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
prev parent reply other threads:[~2021-10-14 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 12:03 [PATCH v2 0/2] Fixups for mtk-cmdq multi-gce support Fei Shao
2021-10-14 12:03 ` [PATCH v2 1/2] mailbox: mtk-cmdq: Validate alias_id on probe Fei Shao
2021-10-14 12:03 ` [PATCH v2 2/2] mailbox: mtk-cmdq: Fix local clock ID usage Fei Shao
2021-10-14 15:55 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWhS1qkwqkmwAyi8@google.com \
--to=tzungbi@google.com \
--cc=chunkuang.hu@kernel.org \
--cc=fshao@chromium.org \
--cc=jason-jh.lin@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome