From: Tejun Heo <tj@kernel.org>
To: menglong8.dong@gmail.com
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
Mengen Sun <mengensun@tencent.com>
Subject: Re: [PATCH] hotfix: make sysfs of unbound kworker cpumask more clever
Date: Thu, 14 Oct 2021 11:23:46 -1000 [thread overview]
Message-ID: <YWif4n0UhaJTf7cp@slm.duckdns.org> (raw)
In-Reply-To: <20211014030641.2182803-1-mengensun@tencent.com>
Hello,
On Thu, Oct 14, 2021 at 11:06:41AM +0800, menglong8.dong@gmail.com wrote:
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 1b3eb1e9531f..8216fc45c77b 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -5394,6 +5394,11 @@ int workqueue_set_unbound_cpumask(cpumask_var_t cpumask)
> cpumask_and(cpumask, cpumask, cpu_possible_mask);
> if (!cpumask_empty(cpumask)) {
> apply_wqattrs_lock();
> + if (cpumask_equal(cpumask, wq_unbound_cpumask)) {
> + apply_wqattrs_unlock();
> + free_cpumask_var(saved_cpumask);
A few nitpicks:
* Please replace "hotfix:" with "workqueue:".
* Can you reorganize the code so that it doesn't have to alloc and free the
saved_mask?
Thanks.
--
tejun
prev parent reply other threads:[~2021-10-14 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 3:06 menglong8.dong
2021-10-14 21:23 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWif4n0UhaJTf7cp@slm.duckdns.org \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®