mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guido Günther" <agx@sigxcpu.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Jyri Sarha <jyri.sarha@iki.fi>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: Ignore -EPROBE_DEFER when bridge attach fails
Date: Fri, 15 Oct 2021 09:33:08 +0200	[thread overview]
Message-ID: <YWkutByrZSLAhVH8@qwark.sigxcpu.org> (raw)
In-Reply-To: <YWiGeAaHoAL6Qga2@ravnborg.org>

Hi Sam,
On Thu, Oct 14, 2021 at 09:35:20PM +0200, Sam Ravnborg wrote:
> Hi Guido,
> 
> > > >  
> > > > +	if (ret != -EPROBE_DEFER) {
> > > >  #ifdef CONFIG_OF
> > > > -	DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > > -		  bridge->of_node, encoder->name, ret);
> > > > +		DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > > +			  bridge->of_node, encoder->name, ret);
> > > 
> > > It would be better to use drm_probe_err().
> > 
> > That's what i thought initially but since the rest here uses DRM_*
> > logging i stuck with it. Happy to change that though.
> 
> If we continue to use the deprecated DRM_ logging functions then we will
> never get rid of them. And then I like the simplicity of
> drm_probe_err().

I wasn't aware those are deprecated. I'll fix that up in case this patch
is needed, which

https://lore.kernel.org/dri-devel/CAMty3ZAsn4K0WFRC_FNN2Mina0gSu4Nc1y1zVsoZ8GuSqcQFsA@mail.gmail.com/

makes it a bit look like it.
Cheers,
  -- Guido

> 
> In the end it is up to you.
> 
> 	Sam
> 

      parent reply	other threads:[~2021-10-15  7:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 19:58 Guido Günther
2021-10-12 20:17 ` Laurent Pinchart
2021-10-12 20:47   ` Guido Günther
2021-10-13  6:02     ` Guido Günther
2021-10-13  6:48     ` Andrzej Hajda
2021-10-13  7:24       ` Guido Günther
     [not found] ` <YWXrPE/G6gaXA6o3@ravnborg.org>
2021-10-12 20:38   ` Guido Günther
     [not found]     ` <YWiGeAaHoAL6Qga2@ravnborg.org>
2021-10-15  7:33       ` Guido Günther [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWkutByrZSLAhVH8@qwark.sigxcpu.org \
    --to=agx@sigxcpu.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyri.sarha@iki.fi \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®