From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Luo Jie <luoj@codeaurora.org>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v2 05/13] net: phy: add qca8081 ethernet phy driver
Date: Fri, 15 Oct 2021 08:54:45 +0100 [thread overview]
Message-ID: <YWkzxd7xzTDngoT9@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211015073505.1893-6-luoj@codeaurora.org>
On Fri, Oct 15, 2021 at 03:34:57PM +0800, Luo Jie wrote:
> @@ -1431,6 +1433,18 @@ static struct phy_driver at803x_driver[] = {
> .get_sset_count = at803x_get_sset_count,
> .get_strings = at803x_get_strings,
> .get_stats = at803x_get_stats,
> +}, {
> + /* Qualcomm QCA8081 */
> + PHY_ID_MATCH_EXACT(QCA8081_PHY_ID),
> + .name = "Qualcomm QCA8081 PHY",
I don't think we need the " PHY" suffix. This name gets printed in a
context where it's obvious it's a network PHY.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-10-15 7:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 7:34 [PATCH v2 0/13] net: phy: Add " Luo Jie
2021-10-15 7:34 ` [PATCH v2 01/13] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS Luo Jie
2021-10-15 7:34 ` [PATCH v2 02/13] net: phy: at803x: use phy_modify() Luo Jie
2021-10-15 7:34 ` [PATCH v2 03/13] net: phy: at803x: improve the WOL feature Luo Jie
2021-10-15 7:34 ` [PATCH v2 04/13] net: phy: at803x: use GENMASK() for speed status Luo Jie
2021-10-15 7:34 ` [PATCH v2 05/13] net: phy: add qca8081 ethernet phy driver Luo Jie
2021-10-15 7:54 ` Russell King (Oracle) [this message]
2021-10-16 9:51 ` Jie Luo
2021-10-15 7:34 ` [PATCH v2 06/13] net: phy: add qca8081 read_status Luo Jie
2021-10-15 7:34 ` [PATCH v2 07/13] net: phy: add qca8081 get_features Luo Jie
2021-10-15 7:35 ` [PATCH v2 08/13] net: phy: add qca8081 config_aneg Luo Jie
2021-10-15 7:35 ` [PATCH v2 09/13] net: phy: add constants for fast retrain related register Luo Jie
2021-10-15 7:35 ` [PATCH v2 10/13] net: phy: add qca8081 config_init Luo Jie
2021-10-15 7:35 ` [PATCH v2 11/13] net: phy: add qca8081 soft_reset and enable master/slave seed Luo Jie
2021-10-15 7:35 ` [PATCH v2 12/13] net: phy: adjust qca8081 master/slave seed value if link down Luo Jie
2021-10-15 8:01 ` Russell King (Oracle)
2021-10-16 9:52 ` Jie Luo
2021-10-15 7:35 ` [PATCH v2 13/13] net: phy: add qca8081 cdt feature Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWkzxd7xzTDngoT9@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoj@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®