From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9013C433F5 for ; Fri, 15 Oct 2021 11:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F6E0611C2 for ; Fri, 15 Oct 2021 11:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238440AbhJOLWl (ORCPT ); Fri, 15 Oct 2021 07:22:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:41416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbhJOLWd (ORCPT ); Fri, 15 Oct 2021 07:22:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E13360EFF; Fri, 15 Oct 2021 11:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634296827; bh=2W8IGoWcN4dnWhDN155etd5POsGBKisgo5d/iujmmAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qcLpHUygt2XOZZ6T820MfK+BnyZQsLnaJMeo65TId0P320j7bFtOVFA/lPiRwN//k vCZwCC48swOSmKkYldE+uOv2I3Tnwh8ZHTXutRs8STV1TSxMD6SEl9AKLZlWv7eagq Nl6JNzF1nrdXys3bLEw4Vk4HI1iKSC1Ne4zThSps= Date: Fri, 15 Oct 2021 13:20:23 +0200 From: Greg KH To: Karolina Drobnik Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vt6655: Rename byPreambleType field Message-ID: References: <20211015102444.90753-1-karolinadrobnik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015102444.90753-1-karolinadrobnik@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 11:24:44AM +0100, Karolina Drobnik wrote: > Drop Hungarian notation prefix in `byPreambleType` member of > struct vnt_private. Change it to use snake case. Update > comment for `bb_get_frame_time` to reflect that change. > > Fix issue detected by checkpatch.pl: > CHECK: Avoid CamelCase: > > Signed-off-by: Karolina Drobnik > --- > drivers/staging/vt6655/baseband.c | 8 ++--- > drivers/staging/vt6655/baseband.h | 2 +- > drivers/staging/vt6655/device.h | 2 +- > drivers/staging/vt6655/device_main.c | 8 ++--- > drivers/staging/vt6655/rxtx.c | 50 ++++++++++++++-------------- > 5 files changed, 35 insertions(+), 35 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > index 0bae35af6e0f..7a5f186f2598 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -1691,7 +1691,7 @@ static const unsigned short awc_frame_time[MAX_RATE] = { > * > * Parameters: > * In: > - * by_preamble_type - Preamble Type > + * preamble_type - Preamble Type This is not part of a structure. > * by_pkt_type - PK_TYPE_11A, PK_TYPE_11B, PK_TYPE_11GB, PK_TYPE_11GA > * cb_frame_length - Baseband Type > * tx_rate - Tx Rate > @@ -1700,7 +1700,7 @@ static const unsigned short awc_frame_time[MAX_RATE] = { > * Return Value: FrameTime > * > */ > -unsigned int bb_get_frame_time(unsigned char by_preamble_type, > +unsigned int bb_get_frame_time(unsigned char preamble_type, Neither is this :( Do not do multiple different things in the same commit and especially when you do not describe them in the changelog text. thanks, greg k-h